[ZK filter] Add per opcode decoder error metrics 2nd attempt #31590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhewei Hu <zhewei.hu33@gmail.com>
Signed-off-by: Zhewei Hu <zhewei.hu33@gmail.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/retest |
1 similar comment
|
/retest |
…empt Signed-off-by: Zhewei Hu <zhewei.hu33@gmail.com>
|
cc @JuniorHsu , please review if you have a chance, thank you! |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: [ZK filter] Add per opcode decoder error metrics 2nd attempt
Additional Description: Reapply #31138 after fixing the ZK proxy filter "Uncaught Exception" issue in #31485.
Risk Level: Low
Testing: Unit test
Docs Changes: docs/root/configuration/listeners/network_filters/zookeeper_proxy_filter.rst
Release Notes: changelogs/current.yaml