grid: cleaning up potential zombie streams #31346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
alt_prot_test
branch
from
dabea30
to
ded03e0
Compare
alyssawilk
force-pushed
the
alt_prot_test
branch
from
1476bad
to
1f2cf44
Compare
alyssawilk
changed the title
|
this may still have a gcc test flake but I think it's ready for a review pass |
| @@ -67,6 +67,18 @@ name: alternate_protocols_cache | |||
| HttpProtocolIntegrationTest::initialize(); | |||
| } | |||
|
|
|||
| void writeFile(uint32_t index) { | |||
There was a problem hiding this comment.
nit: As long as you're here, would you mind renaming this method to something a bit more descriptive? maybe something like "writeAltSvcToFile()" or some such?
| @@ -105,6 +120,7 @@ name: alternate_protocols_cache | |||
| } | |||
| throw EnvoyException("Failed to find a port after 10 tries"); | |||
| } | |||
| bool fill_cache_ = false; | |||
There was a problem hiding this comment.
nit: brief comment on the meaning of this. (Maybe name this something parallel with the new name of the writeFile() method).
test/extensions/filters/http/alternate_protocols_cache/filter_integration_test.cc
Show resolved
Hide resolved
| const std::chrono::milliseconds timeout = TestUtility::DefaultTimeout; | ||
|
|
||
| initialize(); | ||
| codec_client_ = makeHttpConnection(makeClientConnection((lookupPort("http")))); |
There was a problem hiding this comment.
nit: is there an extra set of ()s around lookupPort? Here and elsewhere.
RyanTheOptimist
previously approved these changes
Dec 14, 2023
|
/wait on CI |
RyanTheOptimist
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue where "prefetched" H3 streams were not cleaned up promptly.
Risk Level: low
Testing: new e2e tests
Docs Changes: n/a
Release Notes: inline
[Optional Runtime guard:] yes