Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_reloadable_features_avoid_zombie_streams deprecation #35365

Closed
alyssawilk opened this issue Jul 23, 2024 · 0 comments · Fixed by #35376
Closed

envoy_reloadable_features_avoid_zombie_streams deprecation #35365

alyssawilk opened this issue Jul 23, 2024 · 0 comments · Fixed by #35376
Assignees
@alyssawilk
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #31346 (grid: cleaning up potential zombie streams) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Jul 23, 2024
@alyssawilk alyssawilk self-assigned this Jul 23, 2024
@alyssawilk alyssawilk mentioned this issue Jul 23, 2024
Merged
martinduke pushed a commit to martinduke/envoy that referenced this issue Aug 8, 2024
@alyssawilk @martinduke
runtime: deprecating avoid_zombie_streams (envoyproxy#35376)
571b133 
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes envoyproxy#35365

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
asingh-g pushed a commit to asingh-g/envoy that referenced this issue Aug 20, 2024
@alyssawilk @asingh-g
runtime: deprecating avoid_zombie_streams (envoyproxy#35376)
ace9446 
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes envoyproxy#35365

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: deprecating avoid_zombie_streams alyssawilk/envoy
1 participant
@alyssawilk