Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: deprecating avoid_zombie_streams #35376

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

alyssawilk
Copy link
Contributor

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes #35365

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #35376 was opened by alyssawilk.

see: more, trace.

Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #35376 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk marked this pull request as ready for review July 23, 2024 15:13
@alyssawilk alyssawilk enabled auto-merge (squash) July 23, 2024 15:14
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alyssawilk alyssawilk disabled auto-merge July 24, 2024 15:54
@alyssawilk alyssawilk enabled auto-merge (squash) July 24, 2024 15:56
@alyssawilk alyssawilk merged commit 266fad9 into envoyproxy:main Jul 24, 2024
49 of 50 checks passed
hq6 added a commit to hq6/envoy that referenced this pull request Jul 24, 2024
…ttp1_reverse_bridge_handle_empty_response

* upstream/main:
  tcp conn pool: honor connection_pool_per_downstream_connection (envoyproxy#34763)
  runtime: deprecating avoid_zombie_streams (envoyproxy#35376)
  tracing: xray annotation documentation and CODEOWNER (envoyproxy#35257)
  overload manager: removing exceptions (envoyproxy#35347)
  runtime: remove runtime flag envoy.reloadable_features.abort_filter_chain_on_stream_reset (envoyproxy#35405)
  build(deps): bump nginx from `67682bd` to `6af79ae` in /examples/local_ratelimit in the examples-local-ratelimit group (envoyproxy#35401)
  build(deps): bump postgres from `0aafd2a` to `7963e57` in /examples/shared/postgres (envoyproxy#35400)
  build(deps): bump node from `426d993` to `2fb92fe` in /examples/shared/node (envoyproxy#35399)
  build(deps): bump mysql from 9.0.0 to 9.0.1 in /examples/mysql (envoyproxy#35402)
  build(deps): bump framer-motion from 11.3.8 to 11.3.12 in /examples/single-page-app/ui (envoyproxy#35398)
  build(deps): bump golang from `6c27802` to `af9b40f` in /examples/shared/golang (envoyproxy#35395)
  build(deps): bump redis from `fb534a3` to `5a82749` in /examples/redis (envoyproxy#35397)
  Add %UPSTREAM_CLUSTER_RAW% formatter (envoyproxy#35265)
  Remove runtime flag envoy_reloadable_features_send_header_raw_value (envoyproxy#35388)
  router: removing a few exceptions (envoyproxy#35346)
  Quiche roll 20240717144914 (envoyproxy#35241)
  ext_proc: flow control in observability mode (envoyproxy#35298)
  tls: remove runtime guard `ssl_transport_failure_reason_format` (envoyproxy#35389)
martinduke pushed a commit to martinduke/envoy that referenced this pull request Aug 8, 2024
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes envoyproxy#35365

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
asingh-g pushed a commit to asingh-g/envoy that referenced this pull request Aug 20, 2024
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes envoyproxy#35365

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envoy_reloadable_features_avoid_zombie_streams deprecation
4 participants