Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Endpoint lease for ClusterLoadAssigment #6477

Merged
merged 15 commits into from
Apr 17, 2019

Conversation

vishalpowar
Copy link
Contributor

@vishalpowar vishalpowar commented Apr 3, 2019

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: Add support for specifying _stale_after timeout as part of ClusterLoadAssignment
Risk Level: Low
Optional Feature that is triggered by the Management Server. Defaults to noop.
Testing: Unit test
Docs Changes: None
Release Notes: None
Fixes #6420

vishalpowar and others added 6 commits July 27, 2018 14:38
Pull latest changes from the master
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
@vishalpowar vishalpowar changed the title WIP: Endpoint lease Implementing Endpoint lease for ClusterLoadAssigment Apr 8, 2019
@vishalpowar
Copy link
Contributor Author

/assign htuch

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some minor comments and stats/release notes needed.

source/common/upstream/eds.cc Outdated Show resolved Hide resolved
source/common/upstream/eds.cc Outdated Show resolved Hide resolved
source/common/upstream/eds.cc Outdated Show resolved Hide resolved
source/common/upstream/eds.cc Outdated Show resolved Hide resolved
source/common/upstream/eds.cc Outdated Show resolved Hide resolved
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good modulo a few comments.
/wait

include/envoy/upstream/upstream.h Show resolved Hide resolved
docs/root/intro/version_history.rst Outdated Show resolved Hide resolved
source/common/upstream/eds.cc Outdated Show resolved Hide resolved
test/common/upstream/eds_test.cc Show resolved Hide resolved
Signed-off-by: Vishal Powar <vishalpowar@google.com>
@vishalpowar vishalpowar force-pushed the endpoint_lease branch 2 times, most recently from d3b30b0 to 5a2e85c Compare April 15, 2019 01:47
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few last nits.
/wait

docs/root/intro/version_history.rst Outdated Show resolved Hide resolved
test/common/upstream/eds_test.cc Show resolved Hide resolved
test/common/upstream/eds_test.cc Outdated Show resolved Hide resolved
htuch
htuch previously approved these changes Apr 16, 2019
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vishalpowar! Can you merge master to resolve conflict?

@htuch htuch added the waiting label Apr 16, 2019
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
@vishalpowar
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: release (failed build)

🐱

Caused by: a #6477 (comment) was created by @vishalpowar.

see: more, trace.

@htuch htuch merged commit e6a3ce1 into envoyproxy:master Apr 17, 2019
mpuncel added a commit to mpuncel/envoy that referenced this pull request Apr 19, 2019
* master: (26 commits)
  docs: update docs to recommend /retest repokitteh command (envoyproxy#6655)
  http timeout integration test: wait for 15s for upstream reset (envoyproxy#6646)
  access log: add response code details to the access log formatter (envoyproxy#6626)
  build: add ppc build badge to README (envoyproxy#6629)
  Revert dispatcher stats (envoyproxy#6649)
  Batch implementation with timer (envoyproxy#6452)
  fault filter: reset token bucket on data start (envoyproxy#6627)
  event: update libevent dependency to fix race condition (envoyproxy#6637)
  examples: standardize docker-compose version and yaml extension (envoyproxy#6613)
  quiche: Implement SpdyUnsafeArena using SpdySimpleArena (envoyproxy#6612)
  router: support customizable retry back-off intervals (envoyproxy#6568)
  api: create OpenRCA service proto file (envoyproxy#6497)
  ext_authz: option for clearing route cache of authorized requests (envoyproxy#6503)
  build: update jinja to 2.10.1. (envoyproxy#6623)
  tools: check spelling in pre-push hook (envoyproxy#6631)
  security: blameless postmortem template. (envoyproxy#6553)
  Implementing Endpoint lease for ClusterLoadAssigment (envoyproxy#6477)
  add HTTP integration tests exercising timeouts (envoyproxy#6621)
  event: fix DispatcherImplTest::InitializeStats flake (envoyproxy#6619)
  Add tag extractor for RDS route config name (envoyproxy#6618)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for endpoint lease ( How long endpoints should be used)
2 participants