-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Endpoint lease for ClusterLoadAssigment #6477
Conversation
Pull latest changes from the master
Pull from envoy:master
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
/assign htuch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just some minor comments and stats/release notes needed.
Signed-off-by: Vishal Powar <vishalpowar@google.com>
9e070aa
to
42c808a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good modulo a few comments.
/wait
Signed-off-by: Vishal Powar <vishalpowar@google.com>
d3b30b0
to
5a2e85c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few last nits.
/wait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vishalpowar! Can you merge master to resolve conflict?
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
4a9d146
to
091504a
Compare
/retest |
🔨 rebuilding |
* master: (26 commits) docs: update docs to recommend /retest repokitteh command (envoyproxy#6655) http timeout integration test: wait for 15s for upstream reset (envoyproxy#6646) access log: add response code details to the access log formatter (envoyproxy#6626) build: add ppc build badge to README (envoyproxy#6629) Revert dispatcher stats (envoyproxy#6649) Batch implementation with timer (envoyproxy#6452) fault filter: reset token bucket on data start (envoyproxy#6627) event: update libevent dependency to fix race condition (envoyproxy#6637) examples: standardize docker-compose version and yaml extension (envoyproxy#6613) quiche: Implement SpdyUnsafeArena using SpdySimpleArena (envoyproxy#6612) router: support customizable retry back-off intervals (envoyproxy#6568) api: create OpenRCA service proto file (envoyproxy#6497) ext_authz: option for clearing route cache of authorized requests (envoyproxy#6503) build: update jinja to 2.10.1. (envoyproxy#6623) tools: check spelling in pre-push hook (envoyproxy#6631) security: blameless postmortem template. (envoyproxy#6553) Implementing Endpoint lease for ClusterLoadAssigment (envoyproxy#6477) add HTTP integration tests exercising timeouts (envoyproxy#6621) event: fix DispatcherImplTest::InitializeStats flake (envoyproxy#6619) Add tag extractor for RDS route config name (envoyproxy#6618) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Add support for specifying _stale_after timeout as part of ClusterLoadAssignment
Risk Level: Low
Optional Feature that is triggered by the Management Server. Defaults to noop.
Testing: Unit test
Docs Changes: None
Release Notes: None
Fixes #6420