Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event: fix DispatcherImplTest::InitializeStats flake #6619

Merged
merged 3 commits into from
Apr 17, 2019
Merged

event: fix DispatcherImplTest::InitializeStats flake #6619

merged 3 commits into from
Apr 17, 2019

Conversation

mergeconflict
Copy link
Member

Description: Fix DispatcherImplTest::InitializeStats flake due to dispatcher lifetime exceeding mock stats scope lifetime.
Risk Level: low
Testing: bazel test //test/common/event:dispatcher_impl_test --runs_per_test=1000 (with ASAN enabled)
Docs Changes: n/a
Release Notes: n/a
Fixes #6611

Signed-off-by: Dan Rosen mergeconflict@google.com

Signed-off-by: Dan Rosen <mergeconflict@google.com>
@mergeconflict
Copy link
Member Author

/review @htuch @mattklein123

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a quick comment request.

test/common/event/dispatcher_impl_test.cc Outdated Show resolved Hide resolved
@htuch htuch self-assigned this Apr 17, 2019
Signed-off-by: Dan Rosen <mergeconflict@google.com>
Signed-off-by: Dan Rosen <mergeconflict@google.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@htuch htuch merged commit bad70bf into envoyproxy:master Apr 17, 2019
@mergeconflict mergeconflict deleted the dispatcher_impl_test_flake branch April 18, 2019 18:39
mattklein123 added a commit that referenced this pull request Apr 18, 2019
This reverts commit bad70bf.

Signed-off-by: Matt Klein <mklein@lyft.com>
mpuncel added a commit to mpuncel/envoy that referenced this pull request Apr 19, 2019
* master: (26 commits)
  docs: update docs to recommend /retest repokitteh command (envoyproxy#6655)
  http timeout integration test: wait for 15s for upstream reset (envoyproxy#6646)
  access log: add response code details to the access log formatter (envoyproxy#6626)
  build: add ppc build badge to README (envoyproxy#6629)
  Revert dispatcher stats (envoyproxy#6649)
  Batch implementation with timer (envoyproxy#6452)
  fault filter: reset token bucket on data start (envoyproxy#6627)
  event: update libevent dependency to fix race condition (envoyproxy#6637)
  examples: standardize docker-compose version and yaml extension (envoyproxy#6613)
  quiche: Implement SpdyUnsafeArena using SpdySimpleArena (envoyproxy#6612)
  router: support customizable retry back-off intervals (envoyproxy#6568)
  api: create OpenRCA service proto file (envoyproxy#6497)
  ext_authz: option for clearing route cache of authorized requests (envoyproxy#6503)
  build: update jinja to 2.10.1. (envoyproxy#6623)
  tools: check spelling in pre-push hook (envoyproxy#6631)
  security: blameless postmortem template. (envoyproxy#6553)
  Implementing Endpoint lease for ClusterLoadAssigment (envoyproxy#6477)
  add HTTP integration tests exercising timeouts (envoyproxy#6621)
  event: fix DispatcherImplTest::InitializeStats flake (envoyproxy#6619)
  Add tag extractor for RDS route config name (envoyproxy#6618)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DispatcherImplTest.InitializeStats flake on release builds
2 participants