tap: use move semantics for submitTrace #6709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
mattklein123
requested changes
Apr 26, 2019
source/extensions/common/tap/tap.h
Outdated
| using TraceWrapperSharedPtr = std::shared_ptr<envoy::data::tap::v2alpha::TraceWrapper>; | ||
| inline TraceWrapperSharedPtr makeTraceWrapper() { | ||
| return std::make_shared<envoy::data::tap::v2alpha::TraceWrapper>(); | ||
| using TraceWrapper = envoy::data::tap::v2alpha::TraceWrapper; |
There was a problem hiding this comment.
nit: is this used? Either use it or delete?
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
May 1, 2019
* master: (35 commits) Revert "api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (envoyproxy#6692)" (envoyproxy#6761) Add test for the SocketOptionFactory::buildLiteralOptions() method. (envoyproxy#6724) Add test of parsing weighted_cluster route configuration to improve test coverage. (envoyproxy#6711) test: reducing H2 test permutations, increasing coverage time (envoyproxy#6753) Support gRPC-JSON translate without the google.api.http option. (envoyproxy#6731) quiche: implement QuicEpollClock (envoyproxy#6745) http: rc details for main Envoy workflow (envoyproxy#6560) quiche: implement QuicSystemEventLoopImpl (envoyproxy#6723) http: tracking 100s from upstream in stats (envoyproxy#6746) coverage: run without deprecated option (envoyproxy#6752) quiche: Implement spdy_test_helpers_impl. (envoyproxy#6741) [test] convert listener test stubs to v2 API (envoyproxy#6735) api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (envoyproxy#6692) quiche: Implement http2_reconstruct_object_impl.h. (envoyproxy#6717) build: patch protobuf for UBSAN issue. (envoyproxy#6721) router: scoped rds (2a): scoped routing configuration protos (envoyproxy#6675) tap: use move semantics for submitTrace (envoyproxy#6709) quiche: add epoll_server for testing (envoyproxy#6650) Increase timeout of the coverage test run to 3000 seconds as it is now bumping in the current 2000s limit causing coverage run to abort sometimes. (envoyproxy#6722) quiche: Update tarball to commit 43a1c0f10f2855c3cd142f500e8d19ac6d6f5a8c (envoyproxy#6718) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
May 3, 2019
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes submitTrace use move semantics. If I understand the current code correctly, the existing semantics were de-facto move semantics - this change makes it explicit so the contract is clear.
The goal of this change is to avoid copying the trace once grpc sink is implemented (so that the trace wrapper can be moved to the stream message), by being explicit on the semantics of submitTrace.
Additionally it merges the handling of trace request and response body in
tap_config_impl.ccto reduce code duplication.Next PR should be around introducing a grpc output sink.
Risk Level: Low - does not change functionality.
Testing: Existing tests
Docs Changes: N\A
Release Notes: N\A