test: reducing H2 test permutations, increasing coverage time #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
zuercher
changed the title
htuch
previously approved these changes
Apr 30, 2019
| @@ -353,7 +353,7 @@ TEST_P(Http2CodecImplTest, TrailingHeaders) { | |||
| response_encoder_->encodeTrailers(TestHeaderMapImpl{{"trailing", "header"}}); | |||
| } | |||
|
|
|||
| TEST_P(Http2CodecImplTest, TrailingHeadersLargeBody) { | |||
| TEST_P( Http2CodecImplTest, TrailingHeadersLargeBody) { | |||
|
agree a comment would be good. would you either be Ok with a follow up or force merging so I don't have to wait 2 more hours for coverage to finish? |
|
Force merge is good if we have a successful run now. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
Nope :-( |
alyssawilk
changed the title
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
approved these changes
May 1, 2019
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
May 1, 2019
* master: (35 commits) Revert "api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (envoyproxy#6692)" (envoyproxy#6761) Add test for the SocketOptionFactory::buildLiteralOptions() method. (envoyproxy#6724) Add test of parsing weighted_cluster route configuration to improve test coverage. (envoyproxy#6711) test: reducing H2 test permutations, increasing coverage time (envoyproxy#6753) Support gRPC-JSON translate without the google.api.http option. (envoyproxy#6731) quiche: implement QuicEpollClock (envoyproxy#6745) http: rc details for main Envoy workflow (envoyproxy#6560) quiche: implement QuicSystemEventLoopImpl (envoyproxy#6723) http: tracking 100s from upstream in stats (envoyproxy#6746) coverage: run without deprecated option (envoyproxy#6752) quiche: Implement spdy_test_helpers_impl. (envoyproxy#6741) [test] convert listener test stubs to v2 API (envoyproxy#6735) api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (envoyproxy#6692) quiche: Implement http2_reconstruct_object_impl.h. (envoyproxy#6717) build: patch protobuf for UBSAN issue. (envoyproxy#6721) router: scoped rds (2a): scoped routing configuration protos (envoyproxy#6675) tap: use move semantics for submitTrace (envoyproxy#6709) quiche: add epoll_server for testing (envoyproxy#6650) Increase timeout of the coverage test run to 3000 seconds as it is now bumping in the current 2000s limit causing coverage run to abort sometimes. (envoyproxy#6722) quiche: Update tarball to commit 43a1c0f10f2855c3cd142f500e8d19ac6d6f5a8c (envoyproxy#6718) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
May 3, 2019
…roxy#6753) Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings for edge include
#define HTTP2SETTINGS_EDGE_COMBINE \
::testing::Combine( \
::testing::Values(Http2Settings::MIN_HPACK_TABLE_SIZE, Http2Settings::MAX_HPACK_TABLE_SIZE), \
::testing::Values(Http2Settings::MIN_MAX_CONCURRENT_STREAMS, \
Http2Settings::MAX_MAX_CONCURRENT_STREAMS), \
::testing::Values(Http2Settings::MIN_INITIAL_STREAM_WINDOW_SIZE, \
Http2Settings::MAX_INITIAL_STREAM_WINDOW_SIZE), \
::testing::Values(Http2Settings::MIN_INITIAL_CONNECTION_WINDOW_SIZE, \
Http2Settings::MAX_INITIAL_CONNECTION_WINDOW_SIZE))
The existing codec unit tests don't appear to cover large bodies or many streams, so I think all we need is one test to make sure these settings work. I've done this with the codec header compression test as it seems relevant to hpack table size.
This reduces test run time 8x, and should claw back about 14% of our coverage run time.
Sadly it does not reduce it enough so also bumping coverage time.
Risk Level: n/a
Testing: unit test still passes
Docs Changes: n/a
Release Notes: n/a