Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: enable most abseil checks as errors #7442

Merged

Conversation

derekargueta
Copy link
Member

Description: Enables every abseil clang-tidy check as an error except abseil-no-internal-dependencies because there are ~1500 instances of it. Also broke out each check into a newline so that it's easier to inspect and audit.
Risk Level: Low
Testing: existing
Docs Changes: N/A
Release Notes: N/A

Relates to #4863

Signed-off-by: Derek Argueta dereka@pinterest.com

Signed-off-by: Derek Argueta <dereka@pinterest.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattklein123 mattklein123 merged commit 659805c into envoyproxy:master Jul 2, 2019
@derekargueta derekargueta deleted the dereka/clang-tidy-abseil branch July 2, 2019 04:12
@derekargueta derekargueta mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants