-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed MPI issue #176
Fixed MPI issue #176
Conversation
Avoid lack of memory; (MPI issue) If LocalNumberOfStars becomes zero, reinitialise sendbuffer and reset sendBufferSize.
Thanks for submitting this PR! I'll review it and find two more reviewers, as we require three approvals to merge. |
I guess we fixed the incompatibility with yt-4.0. Maybe we should go back to this pull request? |
Yes, apologies for the delay. Can you pull in that fix which should hopefully fix the tests. |
Hi @setsuna0402 I want to run the tests on this PR before merging after the latest changes to the test suite. I've merged in the changes on my local copy of your fork, but I'm getting permission denied to push. Can you check if "Allow edits by maintainers" is selected on the bottom of the right sidebar? Thanks! |
@jwise77 Sorry, I didn't received your msg. How to change "Allow edits by maintainers"? |
|
@jwise77 I checked the "Allow edits by maintainers" button, and I think I have selected it since the first day. BTW, it is selected now. |
@setsuna0402 I fixed the testing in #190, and I merged in these changes to run the test suite on this PR. But I couldn't push the tags to your PR. Could you issue the command |
Not needed anymore after #190 was merged. |
Avoid lack of memory;
If LocalNumberOfStars becomes zero, reinitialise sendbuffer and reset sendBufferSize.(MPI issue)