Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MPI issue #176

Merged
merged 5 commits into from
Jul 14, 2022
Merged

Conversation

setsuna0402
Copy link
Contributor

Avoid lack of memory;
If LocalNumberOfStars becomes zero, reinitialise sendbuffer and reset sendBufferSize.(MPI issue)

Avoid lack of memory;
(MPI issue)
If LocalNumberOfStars becomes zero, reinitialise sendbuffer and reset sendBufferSize.
@jwise77
Copy link
Contributor

jwise77 commented Aug 10, 2021

Thanks for submitting this PR! I'll review it and find two more reviewers, as we require three approvals to merge.

@setsuna0402
Copy link
Contributor Author

I guess we fixed the incompatibility with yt-4.0. Maybe we should go back to this pull request?

@gregbryan
Copy link
Contributor

Yes, apologies for the delay. Can you pull in that fix which should hopefully fix the tests.

@jwise77
Copy link
Contributor

jwise77 commented Feb 23, 2022

Hi @setsuna0402 I want to run the tests on this PR before merging after the latest changes to the test suite. I've merged in the changes on my local copy of your fork, but I'm getting permission denied to push. Can you check if "Allow edits by maintainers" is selected on the bottom of the right sidebar? Thanks!

@setsuna0402
Copy link
Contributor Author

@jwise77 Sorry, I didn't received your msg. How to change "Allow edits by maintainers"?

@jwise77
Copy link
Contributor

jwise77 commented Apr 27, 2022

@setsuna0402
Copy link
Contributor Author

@jwise77 I checked the "Allow edits by maintainers" button, and I think I have selected it since the first day. BTW, it is selected now.

@jwise77
Copy link
Contributor

jwise77 commented Jul 13, 2022

@setsuna0402 I fixed the testing in #190, and I merged in these changes to run the test suite on this PR. But I couldn't push the tags to your PR. Could you issue the command git fetch https://github.com/jwise77/enzo-dev --tags and then git push --tags to bring in the new gold-standard-v15 tag for testing?

@jwise77
Copy link
Contributor

jwise77 commented Jul 14, 2022

@setsuna0402 I fixed the testing in #190, and I merged in these changes to run the test suite on this PR. But I couldn't push the tags to your PR. Could you issue the command git fetch https://github.com/jwise77/enzo-dev --tags and then git push --tags to bring in the new gold-standard-v15 tag for testing?

Not needed anymore after #190 was merged.

@jwise77 jwise77 merged commit 98b635e into enzo-project:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants