-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating test suite to yt-4.x and concurrent testing #190
Conversation
In particular, the field names and the removal of yt.mods.
Couldn't get concurrent tests to work because of problems with file locks of the answer file.
78f5ab4
to
a6707c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A heroic effort, John! Thanks for doing this. This looks good to me.
Now that the yt infrastructure we rely on is going away, we may want to think about moving to something like what we've setup for Enzo-E. That system can be parallelized automatically using circleci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixing this. Looks good to me. I only have a couple of non-blocking clarification questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to -- just a few duplicated imports. Thanks for doing all of this!
run/MHD/2D/MHD2DRotorTest/MHD2DRotorTest__test_almost_standard.py
Outdated
Show resolved
Hide resolved
run/MHD/2D/MHDCTOrszagTangAMR/MHDCTOrszagTangAMR__test_DivB_CT.py
Outdated
Show resolved
Hide resolved
Britton -- Can you be more specific about what exactly is going away? |
That's good to know about the answer testing infrastructure going away. I've made issue #192 to remind us about it. |
Co-authored-by: Greg Bryan <gbryan@astro.columbia.edu>
Co-authored-by: Greg Bryan <gbryan@astro.columbia.edu>
Co-authored-by: Greg Bryan <gbryan@astro.columbia.edu>
Co-authored-by: Greg Bryan <gbryan@astro.columbia.edu>
You're welcome! I've committed your suggestions. Those duplicates were left over from my find & replace! |
The yt project is transitioning its answer testing from nose to pytest. The |
This looks ready to go -- thanks @jwise77 for fixing testing; now we can address many outstanding pull requests. I'm merging. |
This PR updates all testing infrastructure to be compatible with yt-4.x, including
yt_astro_analysis
forHaloCatalog
callsyt.mods
callsna
withnp
(!)I created a new gold standard (v15) because the old gold-standard cannot be compared to the new runs without some changes to the testing environment (e.g. different packages and dependencies). I manually confirmed on my local machine that the latest PR (#132) passed the push suite before making the new gold standard.
Another big change was using process pools in the
multiprocessing
python module to run the test simulations concurrently. This saves about 10 minutes in the push suite simulations. I couldn't get the testing to run in parallel without putting more effort into it. This could be addressed in a future PR. I increased the CircleCI resource from medium to large since we can run tests in parallel now, and the large nodes are still free to us.Note: There are a lot of duplicate changes in common code in various files, so the review should be easier than what the diff size says.