Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save to Sequence and FASTA doesn't work for monomers loaded from HELM with inline SMILES #2341

Closed
AlexeyGirin opened this issue Sep 9, 2024 · 1 comment · Fixed by #2366 or #2367
Closed

Save to Sequence and FASTA doesn't work for monomers loaded from HELM with inline SMILES #2341

AlexeyGirin opened this issue Sep 9, 2024 · 1 comment · Fixed by #2366 or #2367
Assignees
@AliaksandrDziarkach
Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: High
Milestone
Indigo-1.24.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Toggle to Macro - Flex mode
  2. Load HELM from paste from clipboard way: PEPTIDE1{[N%91[C@H](C%92=O)C.[*:2]%92.[*:1]%91 |$;;;;;_R2;_R1$|].[C%91([C@H](CS%92)N%93)=O.[*:2]%91.[*:1]%93.[*:3]%92 |$;;;;;;_R2;_R1;_R3$|].[C%91([C@H](CC(O%92)=O)N%93)=O.[*:1]%93.[*:2]%91.[*:3]%92 |$;;;;;;;;_R1;_R2;_R3$|].[C([C@@H](C%91=O)N%92)C(C)C.[*:2]%91.[*:1]%92 |$;;;;;;;;_R2;_R1$|]}$$$$V2.0
    image
  3. Save canvas to Sequence (or FASTA)

Actual behavior
Export result is empty
image

Expected behavior
Export result should be XXXX
image

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

Reference issues: #2189
@AlexeyGirin AlexeyGirin added Bug Priority: High HELM Bucket: Bugs related to Export to HELM format labels Sep 9, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.24.0-rc.2 milestone Sep 9, 2024
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Sep 13, 2024
AliaksandrDziarkach added a commit that referenced this issue Sep 13, 2024
@AliaksandrDziarkach
#2341 Save to Sequence and FASTA doesn't work for monomers loaded fr…
5819db5 
…om HELM with inline SMILES

Fix FASTA export. Add UT.
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 13, 2024 that will close this issue
#2341 - Save to Sequence and FASTA doesn't work for monomers loaded from HELM with inline SMILES #2366
Merged
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Sep 13, 2024
@AliaksandrDziarkach
Backmerge: #2341 - Save to Sequence and FASTA doesn't work for monome…
58bba63 
…rs loaded from HELM with inline SMILES

backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Sep 13, 2024 that will close this issue
Backmerge: #2341 - Save to Sequence and FASTA doesn't work for monomers loaded from HELM with inline SMILES #2367
Merged
4 tasks
AlexanderSavelyev pushed a commit that referenced this issue Sep 16, 2024
@AliaksandrDziarkach
#2341 - Save to Sequence and FASTA doesn't work for monomers loaded …
d0e8c14 
…from HELM with inline SMILES (#2366)
AlexanderSavelyev pushed a commit that referenced this issue Sep 16, 2024
@AliaksandrDziarkach
Backmerge: #2341 - Save to Sequence and FASTA doesn't work for monome…
d5b2588 
…rs loaded from HELM with inline SMILES (#2367)
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image
Versions

  • Ketcher Version 2.25.0-rc.3 Build at 2024-09-18; 16:24:03
  • Indigo Toolkit Version 1.24.0-rc.3.0-g692080c62-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.59 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug HELM Bucket: Bugs related to Export to HELM format Priority: High
Projects
None yet
Milestone
Indigo-1.24.0-rc.3
2 participants
@AliaksandrDziarkach @AlexeyGirin