Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2341 - Save to Sequence and FASTA doesn't work for monomers loaded from HELM with inline SMILES #2366

Merged
merged 1 commit into from
Sep 16, 2024
Merged

#2341 - Save to Sequence and FASTA doesn't work for monomers loaded from HELM with inline SMILES #2366

merged 1 commit into from
Sep 16, 2024

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Fix FASTA export. Add UT.

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

For release/xx branch

  • backmerge to master (or newer release/xx) branch is created

@AliaksandrDziarkach
#2341 Save to Sequence and FASTA doesn't work for monomers loaded fr…
5819db5 
…om HELM with inline SMILES

Fix FASTA export. Add UT.
@AliaksandrDziarkach AliaksandrDziarkach linked an issue Sep 13, 2024 that may be closed by this pull request
Save to Sequence and FASTA doesn't work for monomers loaded from HELM with inline SMILES #2341
Closed
@AliaksandrDziarkach AliaksandrDziarkach changed the title #2341 Save to Sequence and FASTA doesn't work for monomers loaded from HELM with inline SMILES #2341 - Save to Sequence and FASTA doesn't work for monomers loaded from HELM with inline SMILES Sep 13, 2024
@AlexanderSavelyev AlexanderSavelyev merged commit d0e8c14 into release/1.24 Sep 16, 2024
74 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the bugfix/2341-wrong-fasta-export branch September 16, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 Awaiting requested review from even1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save to Sequence and FASTA doesn't work for monomers loaded from HELM with inline SMILES
2 participants
@AliaksandrDziarkach @AlexanderSavelyev