Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix: return_likelihood check #333

Merged
merged 1 commit into from
Dec 7, 2022
Merged

bug fix: return_likelihood check #333

merged 1 commit into from
Dec 7, 2022

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Nov 2, 2022

return_likelihood is never greater than 1 - so at the moment setting return_likelihood = TRUE results in failure because log_lik has size 0.

@sbfnk sbfnk marked this pull request as ready for review November 2, 2022 09:57
seabbs
seabbs approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs merged commit e450641 into main Dec 7, 2022
@seabbs seabbs deleted the sbfnk-patch-1 branch December 7, 2022 16:02
sbfnk added a commit that referenced this pull request May 3, 2024
@sbfnk
bug fix: return_likelihood check (#333)
e89078e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbfnk @seabbs