feat: starknet 0.13.1 (without RPC changes) #1766

sistemd · 2024-02-18T13:50:48Z

Support for Starknet v0.13.1 (without RPC changes or P2P changes since the protobufs are not ready yet, oy vey).

This updates blockifier to rc1, the issue to update to the newest blockifier rc is here.

sistemd · 2024-02-18T23:04:38Z

After resolving merge conflicts one of the tests is now failing. The crux of the issue seems to be that P2P protobufs for Starknet v0.13.1 are not quite ready yet, hence I can't specify a valid value for data_availability here. I see two options:

We disable or comment out the test and make sure to note this down in Starknet v0.13.1 P2P changes #1768.
I'm missing something and you guys enlighten me.

sistemd · 2024-02-18T23:28:30Z

crates/compiler/src/lib.rs

+            )
+            .context("Validating Sierra class")?;
+
+        // TODO: determine `max_bytecode_size`


I'm not sure how to do this and I'm not sure if we want to do this at all. I will check this, but I have a feeling this API change is just a consequence of the cairo compiler wanting to add support for a new CLI flag or something like that to let users limit bytecode size. I might be completely wrong though.

I think this new limit is just used by the gateway/sequencer to enforce some recently added limits.

I'm not sure it's terribly important for us to implement the same limit.

I think it would be dangerous to impose any limit at all here. Starkware literally just changed the value for this on starknet without a starknet update. So any check here might cause problems in the future.

Since only "starknet valid" classes should arrive here, we ought to be safe.

Since only "starknet valid" classes should arrive here, we ought to be safe.

That's not entirely true though. DECLARE transactions submitted via starknet_estimateFee / starknet_simulateTransactions also contain a class that ends up being compiled here.

kkovaacs

We'll also have to come up with some new test cases for estimate/trace where l1_da_mode is BLOB.

kkovaacs · 2024-02-19T09:43:16Z

crates/compiler/src/lib.rs

+            )
+            .context("Validating Sierra class")?;
+
+        // TODO: determine `max_bytecode_size`


I think this new limit is just used by the gateway/sequencer to enforce some recently added limits.

I'm not sure it's terribly important for us to implement the same limit.

crates/executor/src/estimate.rs

kkovaacs · 2024-02-19T10:10:38Z

crates/executor/src/execution_state.rs

+                    self.header.strk_l1_data_gas_price.0.try_into().unwrap()
+                },
+            },
+            use_kzg_da: false,


Ah, this will have to get fixed otherwise blockifier won't correctly use data gas.

We'll have to use either true/false depending on the l1_da_mode field of the block header. I guess we'll need to add that to the pathfinder_common::BlockHeader type too.

crates/executor/src/simulate.rs

crates/pathfinder/examples/feeder_gateway.rs

kkovaacs · 2024-02-19T10:45:31Z

crates/rpc/src/gas_price.rs

        {
            Ok(block) => match block {
                MaybePendingBlock::Pending(block) => {
-                    return Some(U256::from(block.eth_l1_gas_price.0));
+                    return Some(U256::from(block.eth_l1_gas_price().0));
                }
                MaybePendingBlock::Block(block) => {
-                    return block.eth_l1_gas_price.map(|gp| U256::from(gp.0));
+                    return block.eth_l1_gas_price().map(|gp| U256::from(gp.0));
                }
            },
            Err(reason) => {


It looks like this is unused (the whole file). We should remove this (as a new PR).

crates/rpc/src/jsonrpc/websocket/data.rs

crates/rpc/src/lib.rs

crates/storage/src/connection/block.rs

crates/storage/src/schema/revision_0049.rs

Mirko-von-Leipzig

This is looking good so far.

crates/executor/src/call.rs

Mirko-von-Leipzig · 2024-02-19T12:24:01Z

crates/executor/src/execution_state.rs

+        let eth_fee_token_address = starknet_api::core::ContractAddress(
+            PatriciaKey::try_from(ETH_FEE_TOKEN_ADDRESS.0.into_starkfelt())
+                .expect("ETH fee token address overflow"),
+        );
+        let strk_fee_token_address = starknet_api::core::ContractAddress(
+            PatriciaKey::try_from(STRK_FEE_TOKEN_ADDRESS.0.into_starkfelt())
+                .expect("STRK fee token address overflow"),
+        );


We could create constants here for these and use tests for equivalence

crates/gateway-types/src/reply.rs

Mirko-von-Leipzig · 2024-02-19T12:44:59Z

crates/rpc/Cargo.toml

Hmm. Not super happy that blockifier makes it way into RPC directly. Ideally it would stay in execution.

The original motivation for this was that we didn't know which execution engine we would be using - starknet-in-rust or blockifier, and constraining the dep to only a single crate might let us exchange them more trivially.

We could add a wrapper type into executor so that we don't need blockifier::ClassInfo here. Adds some extra hoops but does not require adding blockifier to rpc.

sistemd requested a review from a team as a code owner February 18, 2024 13:50

sistemd requested a review from kkovaacs February 18, 2024 13:50

sistemd marked this pull request as draft February 18, 2024 13:54

sistemd removed the request for review from kkovaacs February 18, 2024 13:54

sistemd changed the title ~~feat: starknet 0.13.1~~ feat: starknet 0.13.1 (without RPC changes) Feb 18, 2024

sistemd mentioned this pull request Feb 18, 2024

Starknet v0.13.1 P2P changes #1768

Closed

sistemd force-pushed the sistemd/starknet-0.13.1 branch 2 times, most recently from e72eb9d to 7785820 Compare February 18, 2024 23:10

sistemd commented Feb 18, 2024

View reviewed changes

sistemd mentioned this pull request Feb 18, 2024

Update blockifier to 0.5.0-rc.3 #1769

Closed

sistemd marked this pull request as ready for review February 18, 2024 23:37

sistemd requested a review from kkovaacs February 18, 2024 23:37

kkovaacs reviewed Feb 19, 2024

View reviewed changes

Mirko-von-Leipzig reviewed Feb 19, 2024

View reviewed changes

kkovaacs force-pushed the sistemd/starknet-0.13.1 branch 4 times, most recently from 73f61e1 to 6f1490b Compare February 20, 2024 07:11

kkovaacs and others added 11 commits February 20, 2024 14:31

chore: upgrade blockifier, cairo-vm, starknet_api and compiler

e9c6d92

feat(executor): update for blockifier 0.5.0 API changes

036a7b2

feat(gateway-test-fixtures): add Starknet 0.13.1 block fixtures

d351d01

feat(storage): add data gas price block header fields

08c19b9

feat: add new block header fields

9e0a9ac

fix compiler errors

9c6c156

fix gateway api types

5140b50

workaround for blockifier::BlockInfo, test fixes

da345ed

upgrade blockifier to rc1

bca949f

add methods for accessing gas prices on the feeder gateway dto

31e4a14

fix v06 tests broken by blockifier update

2dfba22

sistemd and others added 6 commits February 20, 2024 14:31

fix v05 tests broken by blockifier update

5d194b5

data gas fee estimation

6228c70

ci

7956fea

feat(common,storage): add l1_da_mode to block header

015016a

chore(rpc): migrate database fixture

503ba27

chore(p2p): disable test until P2P spec catches up

72d9465

kkovaacs force-pushed the sistemd/starknet-0.13.1 branch from f1471f2 to 72d9465 Compare February 20, 2024 13:32

Mirko-von-Leipzig approved these changes Feb 20, 2024

View reviewed changes

kkovaacs merged commit 896f75c into main Feb 20, 2024
7 checks passed

kkovaacs deleted the sistemd/starknet-0.13.1 branch February 20, 2024 14:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: starknet 0.13.1 (without RPC changes) #1766

feat: starknet 0.13.1 (without RPC changes) #1766

sistemd commented Feb 18, 2024 •

edited

Loading

sistemd commented Feb 18, 2024 •

edited

Loading

sistemd Feb 18, 2024

kkovaacs Feb 19, 2024

Mirko-von-Leipzig Feb 19, 2024 •

edited

Loading

kkovaacs Feb 19, 2024

kkovaacs left a comment

kkovaacs Feb 19, 2024

kkovaacs Feb 19, 2024

kkovaacs Feb 19, 2024 •

edited

Loading

Mirko-von-Leipzig left a comment

Mirko-von-Leipzig Feb 19, 2024

Mirko-von-Leipzig Feb 19, 2024

kkovaacs Feb 19, 2024

feat: starknet 0.13.1 (without RPC changes) #1766

feat: starknet 0.13.1 (without RPC changes) #1766

Conversation

sistemd commented Feb 18, 2024 • edited Loading

sistemd commented Feb 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mirko-von-Leipzig Feb 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkovaacs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkovaacs Feb 19, 2024 • edited Loading

Choose a reason for hiding this comment

Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sistemd commented Feb 18, 2024 •

edited

Loading

sistemd commented Feb 18, 2024 •

edited

Loading

Mirko-von-Leipzig Feb 19, 2024 •

edited

Loading

kkovaacs Feb 19, 2024 •

edited

Loading