Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: starknet 0.13.1 (without RPC changes) #1766
feat: starknet 0.13.1 (without RPC changes) #1766
Changes from all commits
e9c6d92
036a7b2
d351d01
08c19b9
9e0a9ac
9c6c156
5140b50
da345ed
bca949f
31e4a14
2dfba22
5d194b5
6228c70
7956fea
015016a
503ba27
72d9465
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to do this and I'm not sure if we want to do this at all. I will check this, but I have a feeling this API change is just a consequence of the cairo compiler wanting to add support for a new CLI flag or something like that to let users limit bytecode size. I might be completely wrong though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this new limit is just used by the gateway/sequencer to enforce some recently added limits.
I'm not sure it's terribly important for us to implement the same limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be dangerous to impose any limit at all here. Starkware literally just changed the value for this on starknet without a starknet update. So any check here might cause problems in the future.
Since only "starknet valid" classes should arrive here, we ought to be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not entirely true though. DECLARE transactions submitted via
starknet_estimateFee
/starknet_simulateTransactions
also contain a class that ends up being compiled here.This file was deleted.