-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for L1 to L2 message log syncing #2251
Conversation
3fcee20
to
fc4b2eb
Compare
fc4b2eb
to
6ff249d
Compare
ab30a2c
to
a935e35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a quite a few comments, most of them in these categories:
- using structured fields in
tracing
macros: https://docs.rs/tracing/latest/tracing/index.html#recording-fields - we should be adding a newtype for L1 block number because we seem to be mixing L1/L2 block numbers at a few places
- using storage row accessors and type conversions for L1 block number / L1 block hash instead of ad-hoc conversions in storage code
l1_tx_hash BLOB NOT NULL, | ||
l2_tx_hash BLOB NOT NULL | ||
); | ||
CREATE INDEX idx_l1_handler_txs_l1_tx_hash ON l1_handler_txs(l1_tx_hash); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thought: the specification seems to require us returning the L2 transaction statuses for an L1 transaction hash in sending order. We do not currently store any information related to that -- we probably should?
a935e35
to
e392a96
Compare
…orage helper methods
e392a96
to
32f49df
Compare
6959268
to
1205c11
Compare
Closed in favor of #2301 |
Introduces functionality to sync L1 to L2 message logs, improving our ability to track cross-chain interactions.
Key Changes
get_logs
method to the Ethereum client:L1ToL2MessageLog
:l1_handler
transactions with corresponding L1 transaction hashesL1BlockNumber
andL1TransactionHash
types to avoid confusionCloses #2243