feat(rpc): Introduce starknet_getMessagesStatus
#2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t00ts
force-pushed
the
t00ts/messaging-proxy
branch
2 times, most recently
from
8bb7b90
to
9ea20d2
Compare
t00ts
changed the title
starknet_getMessagesStatusstarknet_getMessagesStatus
This was referenced Oct 16, 2024
kkovaacs
reviewed
Oct 16, 2024
t00ts
force-pushed
the
t00ts/messaging-proxy
branch
from
9ea20d2
to
65817e6
Compare
kkovaacs
reviewed
Oct 21, 2024
t00ts
force-pushed
the
t00ts/messaging-proxy
branch
3 times, most recently
from
d069a6e
to
fb6f46d
Compare
kkovaacs
approved these changes
Oct 22, 2024
crates/common/src/lib.rs
Outdated
Comment on lines
438
to
448
| impl From<Chain> for ChainId { | ||
| fn from(chain: Chain) -> Self { | ||
| match chain { | ||
| Chain::Mainnet => ChainId::MAINNET, | ||
| Chain::SepoliaTestnet => ChainId::SEPOLIA_TESTNET, | ||
| Chain::SepoliaIntegration => ChainId::SEPOLIA_INTEGRATION, | ||
| Chain::Custom => panic!("Custom chain is not supported"), | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we still need this conversion?
sistemd
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Also introduces new L1BlockNumber for L1 block numbers to avoid confusion, as well as L1TransactionHash.
This is great! The only thing that would have made it only slightly greater is if these were separate PRs because it's easier to review that way 😄
No complaints though, just a small note for the future.
t00ts
force-pushed
the
t00ts/messaging-proxy
branch
from
fb6f46d
to
fb5161c
Compare
t00ts
force-pushed
the
t00ts/messaging-proxy
branch
from
fb5161c
to
996ccb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
starknet_getMessagesStatusAlso introduces new
L1BlockNumberfor L1 block numbers to avoid confusion, as well asL1TransactionHash.Closes #2243
Closes #2182