feat: check class & transaction hashes #2349
Conversation
|
|
||
| #[derive(Debug)] | ||
| pub struct ClassDefinitionWithHash<'a> { | ||
| pub cls_def: ClassDefinition<'a>, |
There was a problem hiding this comment.
Just a small nit: can we maybe call this definition instead?
There was a problem hiding this comment.
Upon reflection, I don't like the whole ClassDefinitionWithHash - now that I've finally fit the carpet, :-) it isn't really used that much...
| }) | ||
| if hash != layout.hash { | ||
| tracing::debug!(input_hash=%layout.hash, actual_hash=%hash, "Class hash mismatch"); | ||
| Err(SyncError2::ClassHashComputationError.into()) |
There was a problem hiding this comment.
nit: I wonder if we should differentiate between a mismatch (ie. proper layout, bad values) and hash computation error (which means bad layout).
So for the former: ClassHashMismatch (maybe we need to add this variant)
and for the latter: ClassHashComputationError (which really is an InvalidDto but at a higher level)
There was a problem hiding this comment.
Well, I wasn't keen on extending SyncError / SyncError2, b/c
- I don't really understand why there's 2 of them, and
- the type isn't used here anyway,
but yes, it can be done...
There was a problem hiding this comment.
Re 1. Don't worry, there will be one error type soon.
vbar
force-pushed
the
vbar/use_cls_tx_hash
branch
from
711d68f to
3705dec
Compare
for equality with locally-computed hashes (and fail on mismatch).
Fixes #2346.