Audit p2p sync errors #2353
Open
Audit p2p sync errors #2353
+427
−480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmitment missing are not fatal errors
CHr15F0x
force-pushed
the
chris/p2p-errors
branch
from
1260dc7
to
fe3f4e4
Compare
Which have no associated peer.
CHr15F0x
force-pushed
the
chris/p2p-errors
branch
from
fe3f4e4
to
ef8ad34
Compare
CHr15F0x
force-pushed
the
chris/p2p-errors
branch
from
064c331
to
5f5ad9c
Compare
vbar
reviewed
Nov 6, 2024
| @@ -1557,6 +1557,8 @@ async fn try_next<T>( | |||
| match count_stream.next().await { | |||
| Some(Ok(cnt)) => Ok(cnt), | |||
| Some(Err(e)) => Err(PeerData::new(PeerId::random(), e)), | |||
| // This is a non-recovarable error, the stream is expected to yield the correct number of | |||
| .map(|x| Self::new(peer, x)) | ||
| .map_err(|e| PeerData::<E>::new(peer, e)) | ||
| } | ||
|
|
||
| pub fn for_tests(data: T) -> Self { |
There was a problem hiding this comment.
could it be behind #[cfg(test)]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2302
Some ideas from the issue ⬆️ were not implemented or a more convenient solution was chosen (for example: log errors at source in checkpoint sync, keep variants small, allow for implicit conversion from
anyhow::Errorbecause only one variant uses it).