Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix tooltip #341

Merged
merged 5 commits into from
Jun 8, 2020
Merged

Bugfix tooltip #341

merged 5 commits into from
Jun 8, 2020

Conversation

pomfrida
Copy link
Contributor

@pomfrida pomfrida commented Jun 3, 2020

Resolves #339

@pomfrida pomfrida requested review from mimarz and vnys as code owners June 3, 2020 08:21
@pomfrida pomfrida self-assigned this Jun 3, 2020
@pomfrida pomfrida added bug-fix core-react eds-core-react labels Jun 3, 2020
@pomfrida pomfrida requested a review from wenche June 3, 2020 09:39
mimarz
mimarz suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in person, we need to handle display on focus/blur on child to show tooltip

@pomfrida pomfrida requested a review from mimarz June 4, 2020 07:53
@pomfrida
Copy link
Contributor Author

pomfrida commented Jun 4, 2020

Ready

wenche
wenche reviewed Jun 4, 2020
View reviewed changes
Copy link
Contributor

@wenche wenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

vnys
vnys approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@vnys vnys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mimarz
mimarz approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pomfrida pomfrida merged commit 9f4a5be into equinor:develop Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenche wenche wenche left review comments

@mimarz mimarz mimarz approved these changes

@vnys vnys vnys approved these changes

Assignees

@pomfrida pomfrida

Labels
core-react eds-core-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip displaying after button is clicked, but hovered away
4 participants
@pomfrida @mimarz @wenche @vnys