Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base Table tokens #910

Merged
merged 17 commits into from
Nov 30, 2020
Merged

Base Table tokens #910

merged 17 commits into from
Nov 30, 2020

Conversation

mimarz
Copy link
Contributor

@mimarz mimarz commented Nov 24, 2020 •
edited
Loading

Lots of changes 🙈

  • Had to do a bigger change in the Cell and Head sub-components to support new base tokens
  • Partially solved Conform typescript types on tokens #678 to figure out how to do different variants/validations for DataCell
    • Added some common types in tokens which was a result from this.
    • Type ComponentToken is meant to be used for all component tokens.
    • Improved templates for better use with typescripts type-safety. (We should use styled-components with an object instead for string template for type-safety)
    • Improved base types for tokens
  • Partially solved Update Table component #297 as I had to refactor Cell because of different typescript types for cell header and data.
  • Changed package.json links to workspace versions as I expect this PR to be merged in after Release eds-core-react@0.7.0 #912

@mimarz mimarz added the core-react eds-core-react label Nov 24, 2020
@mimarz mimarz marked this pull request as ready for review November 26, 2020 09:18
@mimarz mimarz changed the title [WIP] Base Table tokens Base Table tokens Nov 26, 2020
pomfrida
pomfrida approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@pomfrida pomfrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

wenche
wenche approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@wenche wenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mimarz mimarz merged commit 34db330 into equinor:develop Nov 30, 2020
@mimarz mimarz deleted the react/table-tokens branch November 30, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomfrida pomfrida pomfrida approved these changes

@wenche wenche wenche approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

Assignees
No one assigned
Labels
core-react eds-core-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mimarz @wenche @pomfrida