Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NGRM] - in SyncLogviewer, changing displayed wells causes log range to start from 0 #1862

Closed
mirisb opened this issue Jan 10, 2024 · 1 comment · Fixed by #1870
Closed
Assignees
Labels
bug Something isn't working released well-log-viewer

Comments

@mirisb
Copy link
Collaborator

mirisb commented Jan 10, 2024

Storybook story "Demo\SyncLogViewer\Discrete Logs" contains 3 wells showing discrete logs. This story allows controlling the displayed logs. In initial view, the displayed range for all the wells is the combined ranged of the individual wells - from 1350m to 5300m. In this example the domain range is not supplied to the component.

When changing visible wells the range doesn't behave as supposed to - When turning off a well, range does not change and remains original range for all 3 wells. However turning it back on, causes range to be reset and start from 0.

image

@Vladimir-Kokin Vladimir-Kokin added the bug Something isn't working label Jan 16, 2024
@Vladimir-Kokin Vladimir-Kokin self-assigned this Jan 16, 2024
Vladimir-Kokin added a commit that referenced this issue Jan 28, 2024
1. fix initial domain and selection props processing
2. add domain and selection props to SyncLogViewer storybook Discrete
Logs example

See also #1861 for WellLogViewer

Close: #1862
hkfb pushed a commit that referenced this issue Jan 28, 2024
## [1.3.9](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.3.8...well-log-viewer@1.3.9) (2024-01-28)

### Bug Fixes

* Process initial domain and selection props in SyncLogViewer ([#1870](#1870)) ([a4ab40c](a4ab40c)), closes [#1861](#1861) [#1862](#1862)
@hkfb
Copy link
Collaborator

hkfb commented Jan 28, 2024

🎉 This issue has been resolved in version well-log-viewer@1.3.9 🎉

The release is available on GitHub release

@hkfb hkfb added the released label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released well-log-viewer
Projects
None yet
3 participants