feat: PolylinesLayer typed arrays input.

[LeonidPolukhin]

1. PolylinesLayer can accept typed arrays and use them as webgl attributes when possible.
2. ZIncreasingDownwards flag is applied in the vertex shader.
3. depthTest prop is added for uniformity in API with the other layers.

[hkfb]

Btw, did you use the docker container (npm run docker:storybook:test:update) to update the snapshots?

[LeonidPolukhin]

Btw, did you use the docker container (npm run docker:storybook:test:update) to update the snapshots?

Yes, I did. It generated three new images which I submitted but the test fails with disappearing image difference.
The last run: 0.00010850694444444444% different from snapshot (1 differing pixels)
However, in order to run snapshot update on windows with docker running on WSL I needed to modify package.json like this:
"storybook:test": "test-storybook --url http://host.docker.internal:6006/ --no-index-json"

[hkfb]

Btw, did you use the docker container (npm run docker:storybook:test:update) to update the snapshots?

Yes, I did. It generated three new images which I submitted but the test fails with disappearing image difference. The last run: 0.00010850694444444444% different from snapshot (1 differing pixels) However, in order to run snapshot update on windows with docker running on WSL I needed to modify package.json like this: "storybook:test": "test-storybook --url http://host.docker.internal:6006/ --no-index-json"

Could be that the stories are unstable. The axes z order seems not completely stable. You can add the "no-test" tag to skip stories in the smoke tests

[LeonidPolukhin]

Btw, did you use the docker container (npm run docker:storybook:test:update) to update the snapshots?

Yes, I did. It generated three new images which I submitted but the test fails with disappearing image difference. The last run: 0.00010850694444444444% different from snapshot (1 differing pixels) However, in order to run snapshot update on windows with docker running on WSL I needed to modify package.json like this: "storybook:test": "test-storybook --url http://host.docker.internal:6006/ --no-index-json"

Could be that the stories are unstable. The axes z order seems not completely stable. You can add the "no-test" tag to skip stories in the smoke tests

Skipped for now

[hkfb]

Btw, did you use the docker container (npm run docker:storybook:test:update) to update the snapshots?

Yes, I did. It generated three new images which I submitted but the test fails with disappearing image difference. The last run: 0.00010850694444444444% different from snapshot (1 differing pixels) However, in order to run snapshot update on windows with docker running on WSL I needed to modify package.json like this: "storybook:test": "test-storybook --url http://host.docker.internal:6006/ --no-index-json"

Could be that the stories are unstable. The axes z order seems not completely stable. You can add the "no-test" tag to skip stories in the smoke tests

Skipped for now

Suggest also removing the corresponding snapshots.

[LeonidPolukhin]

Btw, did you use the docker container (npm run docker:storybook:test:update) to update the snapshots?

Yes, I did. It generated three new images which I submitted but the test fails with disappearing image difference. The last run: 0.00010850694444444444% different from snapshot (1 differing pixels) However, in order to run snapshot update on windows with docker running on WSL I needed to modify package.json like this: "storybook:test": "test-storybook --url http://host.docker.internal:6006/ --no-index-json"

Could be that the stories are unstable. The axes z order seems not completely stable. You can add the "no-test" tag to skip stories in the smoke tests

Skipped for now

Suggest also removing the corresponding snapshots.

Deleted

[hkfb]

Looks like there is some artifact in the new layer (to the right) compared to the previous. Is this intentional?

[LeonidPolukhin]

Looks like there is some artifact in the new layer (to the right) compared to the previous. Is this intentional?

Indeed. Closed polylines are calculated on the backend by adding the first point as the last one and all the polylines are marked as "open" to prevent the same calculations in deck.gl. As all the polylines are rendered as open ones "z-fighting" can appear where two points coincide.

[hkfb]

🎉 This issue has been resolved in version subsurface-viewer@0.19.0 🎉

The release is available on GitHub release