Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch from nyc to c8 for ESM coverage #534

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Feb 2, 2022

Coverage has been broken since the ESM upgrade (we could add a threshold check to prevent such regressions, though noting that we're just shy of 100% due to https://github.com/eslint/espree/blob/main/lib/espree.js#L132 not being covered).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 2, 2022

CLA Signed

The committers are authorized under a signed CLA.

@bmish
Copy link
Member

bmish commented Feb 2, 2022

What's the difference between the two?

@brettz9
Copy link
Contributor Author

brettz9 commented Feb 2, 2022

What's the difference between the two?

Mostly just the fact that nyc doesn't yet support ESM, and our project switched to ESM. In most other ways, it is just like nyc.

@bmish
Copy link
Member

bmish commented Feb 2, 2022

Makes sense. I saw this change made here too: sindresorhus/eslint-plugin-unicorn#1686

It looks like .gitignore and .nycrc need to be updated too.

@brettz9
Copy link
Contributor Author

brettz9 commented Feb 2, 2022

Makes sense. I saw this change made here too: sindresorhus/eslint-plugin-unicorn#1686

It looks like .gitignore and .nycrc need to be updated too.

No need for nycrc as c8 supports these files too. And no additional folders need supporting for coverage. (And I think we should keep .nyc_output in .gitignore in case reverting back to nyc as we could do (or might need to do for some reason or other) in the future once the new version of nyc may support ESM.)

@brettz9 brettz9 merged commit ea0cf6a into eslint:main Feb 2, 2022
@brettz9 brettz9 deleted the c8 branch February 2, 2022 18:29
@brettz9
Copy link
Contributor Author

brettz9 commented Feb 2, 2022

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants