Replace nyc with c8

[XhmikosR]

https://packagephobia.com/result?p=nyc%2Cc8

[fisker]

#1608 (comment)

[XhmikosR]

Oh, I wasn't aware of that. Let's close it then and someone else can switch it later.

[XhmikosR]

Is it such a big deal, though? I still think it's worth it but I'll leave it to you @fisker @sindresorhus to decide.

Feel free to close it yourselves :)

[fisker]

Can you replace istanbul ignore with c8 ignore?

[XhmikosR]

I pushed a patch to replace istanbul ignore with c8 ignore, but unsure how it'll handle topics or if it's 1-to-1 replacement.

Feel free to push any changes to my branch.

[fisker]

You should move the ignore reason out https://github.com/istanbuljs/v8-to-istanbul/blob/6c2e2ecd2aece8b01543f75dfa203744f8a785b9/lib/source.js#L54

[XhmikosR]

I don't think ignore next ignores the next block, so the statements are not equivalent. It just ignores the next line. The workaround is to specify the lines to ignore...

EDIT: ignore if isn't also a thing with c8 it seems.

[fisker]

There are ignore start and ignore end we can use.

[XhmikosR]

In most cases it should be fine doing c8 ignore next 3 and it's shorter. Are you OK with this?

[fisker]

Yes.

[XhmikosR]

All right, this is as good as it gets from my side :)

Feel free to tweak it further if needed.

[fisker]

LGTM, Thank You!