Add CRC and MD5 HIL tests #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
jessebraham
reviewed
Apr 10, 2024
| use super::*; | ||
|
|
||
| #[init] | ||
| fn init() {} |
There was a problem hiding this comment.
Just out of curiosity, does embedded_test require an init function, or are we just including it to be consistent with the other tests? It's not a problem at all as-is, of course.
There was a problem hiding this comment.
Its not required afaik. I left it to match the other tests, but I can remove it. No hard opinion tbh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Adds an HIL test for CRC and MD5. Not sure how useful are this tests since they are mostly calling ROM functions, but I thought it might be good to have them.
Testing
Tested locally on C3,C6 and H2. Also, I manually triggered the HIL CI to run in my fork/branch of this PR: https://github.com/esp-rs/esp-hal/actions/runs/8629177503