Add erase-flash, erase-region, and erase-parts subcommands

[jnross]

No description provided.

[jnross]

Whoops, I didn't mean to close this PR. I landed the branch in our fork, but shouldn't have deleted the branch.

[jnross]

I rebased this on top of #465. That should land first before this one.

[SergioGasquez]

Same as #461, we want to keep the CLI as it is (for the moment) to avoid having to bump SemVer major. This will be later addressed in #473

[jnross]

Thanks for the comments here and in #461. I'll make these changes to avoid the need for the SemVer bump.

[jnross]

Ok, I think I've resolved the concerns here. This PR now proposes no changes to cli/mod.rs, and only additive changes and bug fixes to flasher/mod.rs.

[SergioGasquez]

I left some minor comments and also have a few suggestions:

• Can we implement the subcommands also for cargo-espflash?
  • Note that we don't require partition_table for erase-parts in cargo-espflash as it can be obtained from the package metadada, or it will result in a similar issue to #390
• EraseFlash and EraseRegion are only available when using stub
  • It would be great if we could check if we are using a stub, if not, throw an informative error
    • esptool does not have such check or I haven't found it
    • This might not be possible to do without breaking semver. If that's the case we can just open an issue for the future
  • At the moment, if you flash with no-stub and then do an erase-flash and you get invalid header: 0xffffffff

[jnross]

Thanks @SergioGasquez for taking a detailed look and for these great suggestions. I'll work them into my branch.

[jnross]

@SergioGasquez : In this PR as originally authored, there were changes to cli/mod.rs, but they were additive only. There were new pub structs and functions added, but none of the existing interface was altered or broken. Isn't that permitted in a minor version bump in SemVer? I'd working on adding these subcommands to cargo-espflash, but without making additive changes to cli/mod.rs there's quite a bit of duplicated code required.

[jnross]

@SergioGasquez : I adopted all of your suggestions. Then I went about adding support for these subcommands to cargo-espflash, and found that I would have to duplicate several new structs and new functions in both espflash/src/bin/espflash.rs and cargo-espflash/src/main.rs. Since these structs and functions are purely additive this shouldn't require a major SemVer bump, only a minor one.

I'd ask that you take a close look at the erase-parts implementation in cargo-espflash. I wasn't sure if I should require a build there, or whether I should fail if a cargo package isn't found in the current directory or per the --package argument, as long as an alternative --partition-table is provided.

[SergioGasquez]

Just a small comment to avoid using bail! and use a defined Error that we can reuse

[jnross]

@SergioGasquez: Thanks for catching that, you're quite right I should have defined a single error for these cases. Fixed in 22d792a

[SergioGasquez]

Thanks for the quick fixes! One last detail!

[SergioGasquez]

LGTM! Thanks for the contribution and for addressing all the changes!

[jnross]

Thanks for your stewardship and excellent suggestions here. I'm happy to see these changes get integrated.