Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to erase all flash #460

Closed
jnross opened this issue Aug 18, 2023 · 0 comments · Fixed by #462
Closed

Add command to erase all flash #460

jnross opened this issue Aug 18, 2023 · 0 comments · Fixed by #462
Labels
enhancement New feature or request

Comments

@jnross
Copy link
Contributor

jnross commented Aug 18, 2023

In some of our workflows we're still using esptool.py for its erase_flash command. Sometimes we can avoid this with the --erase-parts option on the flash subcommand, but it's awkward that we need to provide an ELF binary to flash when we're only trying to erase data.

I propose that an erase subcommand be added, with options to erase all flash, or to erase only named partitions.
jnross added a commit to junelife/espflash that referenced this issue Aug 21, 2023
@jnross
Add command to erase flash. (For esp-rs#460)
1786b53
jnross added a commit to junelife/espflash that referenced this issue Aug 22, 2023
@jnross
Erase flash (#3)
907a6e4 
* Add command to erase flash. (For esp-rs#460)

* Add `erase-parts` command to erase named partitions.

* Fix timeout logic when erasing regions.
jnross added a commit to junelife/espflash that referenced this issue Aug 22, 2023
@jnross
Erase flash (#3)
f59218f 
* Add command to erase flash. (For esp-rs#460)

* Add `erase-parts` command to erase named partitions.

* Fix timeout logic when erasing regions.
jnross added a commit to junelife/espflash that referenced this issue Aug 22, 2023
@jnross
Erase flash (#3)
309d278 
* Add command to erase flash. (For esp-rs#460)

* Add `erase-parts` command to erase named partitions.

* Fix timeout logic when erasing regions.
jnross added a commit to junelife/espflash that referenced this issue Aug 25, 2023
@jnross
Add command to erase flash. (For esp-rs#460)
60c8d16
@jnross jnross mentioned this issue Aug 25, 2023
Merged
jnross added a commit to junelife/espflash that referenced this issue Sep 12, 2023
@jnross
Add command to erase flash. (For esp-rs#460)
80263dc
@jessebraham jessebraham added the enhancement New feature or request label Sep 14, 2023
@SergioGasquez SergioGasquez linked a pull request Sep 18, 2023 that will close this issue
Add erase-flash, erase-region, and erase-parts subcommands #462
Merged
jnross added a commit to junelife/espflash that referenced this issue Sep 24, 2023
@jnross
Add command to erase flash. (For esp-rs#460)
6bd6261
SergioGasquez added a commit that referenced this issue Sep 29, 2023
@jnross @SergioGasquez
Add erase-flash, erase-region, and erase-parts subcommands (#462)
59a8243 
* Add command to erase flash. (For #460)

* Add `erase-parts` command to erase named partitions.

* Fix timeout logic when erasing regions.

* Reset device after `erase_flash` or `erase_parts` commands.

* Add support for `erase-region` subcommand.

* Avoid changes to `cli/mod.rs`

* Address PR comments.  Add subcommands to `cargo-espflash` too.

* Fix clippy violation.

* Factor out error for erase failure when `--no-stub` is specified.

* Improve guidance around StubRequiredToEraseFlash

Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>

---------

Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add erase-flash, erase-region, and erase-parts subcommands junelife/espflash
2 participants
@jnross @jessebraham