-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial HIL testing #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
force-pushed
the
feat/hil
branch
from
February 22, 2024 15:03
0cfc7d3
to
76d322d
Compare
3 tasks
SergioGasquez
force-pushed
the
feat/hil
branch
4 times, most recently
from
February 23, 2024 14:16
91f33e9
to
bf0f4df
Compare
SergioGasquez
force-pushed
the
feat/hil
branch
from
February 23, 2024 14:23
bf0f4df
to
81dbb18
Compare
HIL CI is now green! Only CI on macos is failing due to: #597. The only thing left would be to decide when the HIL CI should run. |
MabezDev
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job! Very excited to see this merged!
Thank you @SergioGasquez and @achxkloel for taking care of this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HIL CI that:
In Ubuntu runners, build esp-halhello_world
example for every target, upload artifacts to actionsboard-info
, checks that "esp32" is printedflash
, checks that "Flashing has completed!" is printedmonitor
for 5secs, checks that "Hello world!" is printederase-flash
, checks that "Flash has been erased!" is printedread-flash
, checks that "Flash content successfully read and written to" is printedhexdump
to verify that read flash is empty (its been erased, so it should be)save-image
, checks that "Image successfully saved!" is printedwrite-bin
, checks that "Binary successfully written to flash!" is printedmonitor
for 5secs, checks that "Hello world!" is printedinfo!
logs for when the command ends successfullynon-interactive
flag to monitoring so it can be used in CIHIL CI errors:ESP32 is failing when trying to flash the board, not sure what is happening there.ESP32-C2 seems to be offline.ESP32-C3 fails as its a rust board and it cant read the uart.ESP32-C2 cant monitor. Its a 26MHz C2 and it only reads noiseWe would also need to decide when this action runs
Thanks to @achxkloel for the investigation on the monitoring issue