Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds voice assistant announce #939

Conversation

synesthesiam
Copy link
Contributor

@synesthesiam synesthesiam commented Aug 29, 2024

Copy link
Contributor

coderabbitai bot commented Aug 29, 2024

Walkthrough

The changes enhance the voice assistant functionality in the aioesphomeapi module by introducing a new enumeration for pipeline stages and message types for managing announcements. New methods for sending and waiting for media announcements have been added, along with updates to response handling and feature representation, thereby expanding the capabilities of the voice assistant.

Changes

Files Change Summary
aioesphomeapi/api.proto Added VoiceAssistantPipelineStage enum, VoiceAssistantPipelineRunConfig message, and VoiceAssistantAnnounceRequest message.
aioesphomeapi/client.py Introduced send_voice_assistant_announce and wait_voice_assistant_announce methods for handling media announcements, and updated subscribe_voice_assistant.
aioesphomeapi/core.py Imported VoiceAssistantAnnounceRequest and VoiceAssistantAnnounceFinished, updated response mapping to include them.
aioesphomeapi/model.py Added ANNOUNCE value to VoiceAssistantFeature enum and created VoiceAssistantAnnounceFinished class.
tests/test_client.py Added test_send_voice_assistant_announcement_await_response to validate announcement behavior and included new imports.
tests/test_connection.py Modified context manager syntax in _do_finish_connect function for exception assertion.

Possibly related PRs

Suggested labels

new-feature


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

aioesphomeapi/client.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (be2a3a3) to head (c053bb5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #939   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          17       17           
  Lines        2628     2635    +7     
=======================================
+ Hits         2625     2632    +7     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member

bdraco commented Sep 3, 2024

I fixed codecov so it should report correctly now

aioesphomeapi/client.py Outdated Show resolved Hide resolved
@synesthesiam synesthesiam force-pushed the synesthesiam-20240829-voice-assistant-announce branch from 21abd23 to 83bff59 Compare September 4, 2024 14:19
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

aioesphomeapi/client.py Outdated Show resolved Hide resolved
aioesphomeapi/client.py Outdated Show resolved Hide resolved
@synesthesiam
Copy link
Contributor Author

Added a test. This should be good to go now.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

aioesphomeapi/model.py Outdated Show resolved Hide resolved
synesthesiam and others added 2 commits September 5, 2024 10:27
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@jesserockz jesserockz merged commit 3ca83b2 into esphome:main Sep 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants