Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synesthesiam 20240828 esphome entity #124886

Closed
wants to merge 8 commits into from
Closed

Synesthesiam 20240828 esphome entity #124886

wants to merge 8 commits into from

Conversation

synesthesiam
Copy link
Contributor

@synesthesiam synesthesiam commented Aug 29, 2024 •
edited
Loading

Breaking change

Proposed change

Ports ESPHome voice assistant code to AssistSatelliteEntity and adds two websocket commands for assist_satellite:

  1. assist_satellite/intercept_wake_word - intercepts the next wake word on the satellite and returns it
  2. assist_satellite/announce - announces text or a media id on the satellite

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

synesthesiam and others added 7 commits August 25, 2024 16:19
@synesthesiam
Add Assist satellite entity + VoIP (#123830)
644427e 
* Add assist_satellite and implement VoIP

* Fix tests

* More tests

* Improve test

* Update entity state

* Set state correctly

* Move more functionality into base class

* Move RTP protocol into entity

* Fix tests

* Remove string

* Move to util method

* Align states better with pipeline events

* Remove public async_get_satellite_entity

* WAITING_FOR_WAKE_WORD

* Pass entity ids for pipeline/vad sensitivity

* Remove connect/disconnect

* Clean up

* Final cleanup
@synesthesiam @balloob
Incorporate assist satellite entity feedback (#124727)
a51de1d 
* Incorporate feedback

* Raise value error

* Clean up entity description

* More cleanup

* Move some things around

* Add a basic test

* Whatever

* Update CODEOWNERS

* Add tests

* Test tts response finished

* Fix test

* Wrong place

---------

Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@synesthesiam
Before refactor
7fe4a52
@synesthesiam
Update tests
d375bfa
@synesthesiam
Add async_announce
f0c49b3
@synesthesiam
Dynamically set supported features
93cc266
@synesthesiam
Resolve media id if present
1a6affc
@home-assistant
Copy link

Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration (voip) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of voip can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign voip Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @OttoWinter, @jesserockz, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

This was referenced Aug 29, 2024
Merged
Merged
Merged
@synesthesiam
Copy link
Contributor Author

Leaving as a draft since this is still under discussion and more tests need to be added.

@balloob balloob mentioned this pull request Aug 30, 2024
Merged
19 tasks
@balloob balloob mentioned this pull request Aug 30, 2024
Merged
19 tasks
@synesthesiam synesthesiam force-pushed the assist-satellite branch 2 times, most recently from eedee04 to 99a4942 Compare August 30, 2024 21:19
@balloob balloob mentioned this pull request Aug 31, 2024
Merged
19 tasks
@synesthesiam
Copy link
Contributor Author

Splitting into multiple PRs

@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob left review comments

@OttoWinter OttoWinter Awaiting requested review from OttoWinter OttoWinter will be requested when the pull request is marked ready for review OttoWinter is a code owner

@jesserockz jesserockz Awaiting requested review from jesserockz jesserockz will be requested when the pull request is marked ready for review jesserockz is a code owner

@kbx81 kbx81 Awaiting requested review from kbx81 kbx81 will be requested when the pull request is marked ready for review kbx81 is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco will be requested when the pull request is marked ready for review bdraco is a code owner

Assignees

@bdraco bdraco

@balloob balloob

@jesserockz jesserockz

@OttoWinter OttoWinter

Labels
by-code-owner cla-signed has-tests integration: assist_satellite integration: esphome integration: voip new-feature Quality Scale: internal Quality Scale: platinum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@synesthesiam @balloob @bdraco @jesserockz @OttoWinter