Bump go toolchain to 1.23.0 #96
Conversation
Reference: - etcd-io/etcd#18443 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Reference: - https://github.com/golangci/golangci-lint/releases/tag/v1.60.1 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
There was a problem hiding this comment.
Thanks for raising @henrybear327 - Just one more item to tweak for the Dockerfile.
Reference: - https://github.com/golangci/golangci-lint/releases/tag/v1.60.1 - https://github.com/etcd-io/auger/pulls#discussion_r1718213564 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
|
/cc @ivanvc |
| @@ -13,7 +13,7 @@ jobs: | |||
| - name: golangci-lint | |||
| uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0 | |||
| with: | |||
| version: v1.59.1 | |||
| version: v1.60.1 | |||
There was a problem hiding this comment.
I spotted this also in bbolt. Do we want to lock a version here? I think the only way to bump the version would be manually. Would it be better to set it to latest (refer to their documentation).
@jmhbnz, WDYT?
There was a problem hiding this comment.
I think maybe we would like to follow the dependency pinning everywhere, though using the latest tag would be nicer for the linter since the update can come right away.
There was a problem hiding this comment.
Yes, however, dependabot won't update this. I think it may also not be that relevant when we migrate these jobs to Prow.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: henrybear327, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reference: