Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go toolchain to 1.23.0 #96

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Bump go toolchain to 1.23.0 #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5178c37
Bump go toolchain to 1.23.0
henrybear327 Aug 14, 2024
63ed0b0
Update golangci-lint to v1.60.1
henrybear327 Aug 14, 2024
47e3087
Bump docker image
henrybear327 Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/static-analysis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0
with:
version: v1.59.1
version: v1.60.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted this also in bbolt. Do we want to lock a version here? I think the only way to bump the version would be manually. Would it be better to set it to latest (refer to their documentation).

@jmhbnz, WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe we would like to follow the dependency pinning everywhere, though using the latest tag would be nicer for the linter since the update can come right away.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, however, dependabot won't update this. I think it may also not be that relevant when we migrate these jobs to Prow.

args: --config tools/.golangci.yaml
- run: |
set -euo pipefail
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM docker.io/golang@sha256:58e52f6ddd39098d23b1a34ec24024acd5fe182245960afe572d83c313aafbed
FROM docker.io/golang@sha256:d0b31558e6b3e4cc59f6011d79905835108c919143ebecc58f35965bf79948f4

RUN apk add --no-cache curl git make && rm -rf /var/cache/apk/*

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

NAME ?= auger
PKG ?= github.com/etcd-io/$(NAME)
GO_VERSION ?= 1.22.6
GO_VERSION ?= 1.23.0
GOOS ?= linux
GOARCH ?= amd64
TEMP_DIR := $(shell mktemp -d)
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/etcd-io/auger

go 1.22.0
go 1.23
henrybear327 marked this conversation as resolved.
Show resolved Hide resolved

toolchain go1.22.6
toolchain go1.23.0

require (
github.com/google/safetext v0.0.0-20220914124124-e18e3fe012bf
Expand Down