Add internal iterator to Bucket that goes over buckets. #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
force-pushed
the
20221215-flags
branch
from
eb6f2ce
to
7e057ea
Compare
ahrtr
reviewed
Dec 21, 2022
cursor.go
Outdated
| return k, v | ||
| } | ||
|
|
||
| func (c *Cursor) first() (key []byte, value []byte, flags uint32) { | ||
| _assert(c.bucket.tx.db != nil, "tx closed") |
There was a problem hiding this comment.
Suggest to keep the existing check behavior: only check the _assert(c.bucket.tx.db != nil, "tx closed") on the exported Methods (e.g. First, Last, Next, Prev).
But seek is an abnormal example. We may need to move the check to Seek.
ahrtr
reviewed
Dec 21, 2022
bucket_test.go
Outdated
| } | ||
| err := db.Update(func(tx *bolt.Tx) error { | ||
| b, err := tx.CreateBucket([]byte("widgets")) | ||
| assert.NoError(t, err, "bucket creation failed") |
There was a problem hiding this comment.
You might need to use require.NoError. Note assert.NoError will not terminate the execution of the case if it fails. Obviously it doesn't make sense to continue to execute if creaing bucket fails.
There was a problem hiding this comment.
Thank you. It's misleading in testify that assertions are not an assertions.
Done.
|
Overall looks good to me. Please resolve the conflict. |
So far the code was frequently traversing all the keys (ignoring flag whether key is a bucket) and trying to open each of the keys as bucket (seeking the same entry from the scratch). In this proposal, we iterate only through bucket keys. Signed-off-by: Piotr Tabor <ptab@google.com>
ptabor
force-pushed
the
20221215-flags
branch
from
7e057ea
to
ebca452
Compare
|
Thank you for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the code was frequently traversing all the keys (ignoring flag whether key is a bucket) and trying to open each of the keys as bucket (seeking the same entry from the scratch).
In this proposal, we iterate only through bucket keys.
Signed-off-by: Piotr Tabor ptab@google.com