Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: upgraded golang.org/x/sys #349

Closed
wants to merge 1 commit into from

Conversation

siennathesane
Copy link

Upgraded golang.org/x/sys from v0.2.0 to account for golang/go#49219.

Fixes #348

Signed-off-by: Sienna Lloyd sienna@linux.com

Upgraded golang.org/x/sys from v0.2.0 to account for golang/go#49219.

Signed-off-by: Sienna Lloyd <sienna@linux.com>
@ahrtr
Copy link
Member

ahrtr commented Nov 23, 2022

Thanks @mxplusb for the PR. I would suggest to wait for the next tag version (e.g. v0.3.0). You can use golang 1.17 to execute go install ... command, or build it directly if you want to use golang 1.18 or 1.19.

@ptabor
Copy link
Contributor

ptabor commented Dec 15, 2022

ptab-macbookpro2:bbolt ptab$ go version
go version go1.19.4 darwin/arm64

ptab-macbookpro2:bbolt ptab$ go install -v go.etcd.io/bbolt/cmd/bbolt@latest
go: downloading golang.org/x/sys v0.0.0-20200923182605-d9f96fdee20d
golang.org/x/sys/internal/unsafeheader
golang.org/x/sys/unix
go.etcd.io/bbolt
go.etcd.io/bbolt/cmd/bbolt

So it worked... and it downloded 20200923 version despite having require golang.org/x/sys v0.2.0

@ptabor
Copy link
Contributor

ptabor commented Dec 15, 2022

Actually there is v0.3.0 already: https://pkg.go.dev/golang.org/x/sys?tab=versions

@ahrtr
Copy link
Member

ahrtr commented Dec 15, 2022

Thanks @ptabor .

@mxplusb Would you mind updating this PR to bump to v0.3.0?

@ahrtr ahrtr added the resurrection The PR makes sense but not responsive. So please anyone feel free to resurrect this PR label Dec 21, 2022
@ahrtr
Copy link
Member

ahrtr commented Dec 21, 2022

Resolved in #356

@ahrtr ahrtr closed this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resurrection The PR makes sense but not responsive. So please anyone feel free to resurrect this PR
Development

Successfully merging this pull request may close these issues.

bbolt CLI fails to compile with linker errors
3 participants