Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RO db should allow access to tx.Page(...) thus bbolt pages #371

Closed
wants to merge 1 commit into from
Closed

RO db should allow access to tx.Page(...) thus bbolt pages #371

wants to merge 1 commit into from

Commits on Jan 3, 2023

  1. RO db should allow access to tx.Page(...) thus bbolt pages 

    I discoved that after change etcd-io#365 the
'bbolt pages' command stopped working.

The problem is this check:
https://github.com/etcd-io/bbolt/blob/b654ce922133ff49bb385297f30835ca357bac5f/tx.go#L663
that assumes that freepages has been loaded.

We can either preload the freepages when opening a RO file:
  https://github.com/etcd-io/bbolt/blob/b654ce922133ff49bb385297f30835ca357bac5f/db.go#L280-L284
but this would slow-down opening RO files.

Thus for now I disable checking whether page is free...

Signed-off-by: Piotr Tabor <ptab@google.com>
    @ptabor
    ptabor committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    ac3ef86 View commit details
    Browse the repository at this point in the history