-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace endpoint.ParseHostPort with net.SplitHostPort to fix IPv6 client endpoints #11211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM, thanks for the quick fix. |
gyuho
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the quick fix
given kubernetes/kubernetes is at 3.3.15 would it be possible to also backport for 3.3? |
lgtm, thanks Joe! +1 on backporting to 3.3, ref: kubernetes/kubernetes#83209 (comment) |
liggitt
reviewed
Oct 8, 2019
This was referenced Oct 8, 2019
jpbetz
added a commit
that referenced
this pull request
Oct 9, 2019
…-origin-release-3.3 Automated cherry pick of #11211
jpbetz
added a commit
that referenced
this pull request
Oct 9, 2019
…-origin-release-3.4 Automated cherry pick of #11211
This was referenced Oct 10, 2019
Merged
spzala
added a commit
to spzala/etcd
that referenced
this pull request
Dec 2, 2019
spzala
added a commit
to spzala/etcd
that referenced
this pull request
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kubernetes/kubernetes#83550
Manually verified fix:
We need a automated test for this too. Since we don't have any IPv6 tests in etcd, we need to enable that test carefully, since it would fail in environments without IPv6 enabled. We will do that as a follow up PR.
Regenerated all the test certs after adding one with an IPv6 IP for the manual test. We'll keep the cert around for when we add the automated test.
cc @liggitt @gyuho @jingyih @wenjiaswe @YoyinZyc @hangxie