Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: add missing changelogs #11411

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Conversation

spzala
Copy link
Member

@spzala spzala commented Dec 2, 2019

related #11184 #11211 #11354

@spzala
Copy link
Member Author

spzala commented Dec 2, 2019

/cc @jingyih

@spzala spzala requested a review from jingyih December 2, 2019 18:11
@spzala
Copy link
Member Author

spzala commented Dec 2, 2019

Hi @jingyih - updating changelog here per our discussion in the #11354 Thanks!

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #11411 into master will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11411      +/-   ##
==========================================
- Coverage   64.58%   63.84%   -0.75%     
==========================================
  Files         403      403              
  Lines       37969    37969              
==========================================
- Hits        24522    24240     -282     
- Misses      11814    12091     +277     
- Partials     1633     1638       +5
Impacted Files Coverage Δ
client/client.go 42.81% <0%> (-30.72%) ⬇️
client/keys.go 70.35% <0%> (-21.11%) ⬇️
auth/range_perm_cache.go 48.1% <0%> (-12.66%) ⬇️
clientv3/naming/grpc.go 63.15% <0%> (-12.29%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
auth/store.go 51.97% <0%> (-10.61%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
pkg/netutil/netutil.go 63.11% <0%> (-5.74%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
clientv3/leasing/txn.go 88.09% <0%> (-3.18%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1139d3...a45b997. Read the comment docs.

CHANGELOG-3.3.md Outdated

- Improve [client balancer failover against multiple endpoints](https://github.com/etcd-io/etcd/pull/11184).
- Fix ["kube-apiserver: failover on multi-member etcd cluster fails certificate check on DNS mismatch" (kubernetes#83028)](https://github.com/kubernetes/kubernetes/issues/83028).
- Improve [client balancer failover against IPv6 endpoints](https://github.com/etcd-io/etcd/pull/11211).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, the fix is for parsing IPv6 in etcd client, not necessarily related to client balancer failover. So maybe something like Fix IPv6 endpoint parsing in client?

Given that they are bug fixes, maybe put these under section client v3 instead of breaking changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jingyih sure, sounds good. Thanks!!

@jingyih
Copy link
Contributor

jingyih commented Dec 2, 2019

@gyuho @jpbetz could you help take a look?

@gyuho
Copy link
Contributor

gyuho commented Jan 20, 2020

Can we name the section "Package clientv3"

@spzala
Copy link
Member Author

spzala commented Jan 20, 2020

Can we name the section "Package clientv3"

Hi @gyuho thanks and I believe you are referencing changelog 3.3 and 3.4? If so, yes, I am fine with it but originally I put client v3 to keep it consistent with other places in the 3.3 and 3.4. (for example,
https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.3.md#client-v3
https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.3.md#client-v3-2
https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.3.md#client-v3-3
https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.4.md#client-v3
) So please let me know if you want to keep it as such or change it? Thanks!

@gyuho
Copy link
Contributor

gyuho commented Jan 20, 2020

oh ok. then this looks good as well

@gyuho gyuho merged commit d17a607 into etcd-io:master Jan 20, 2020
@spzala
Copy link
Member Author

spzala commented Jan 20, 2020

oh ok. then this looks good as well

OK Thanks @gyuho !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants