-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG: add missing changelogs #11411
Conversation
/cc @jingyih |
Codecov Report
@@ Coverage Diff @@
## master #11411 +/- ##
==========================================
- Coverage 64.58% 63.84% -0.75%
==========================================
Files 403 403
Lines 37969 37969
==========================================
- Hits 24522 24240 -282
- Misses 11814 12091 +277
- Partials 1633 1638 +5
Continue to review full report at Codecov.
|
CHANGELOG-3.3.md
Outdated
|
||
- Improve [client balancer failover against multiple endpoints](https://github.com/etcd-io/etcd/pull/11184). | ||
- Fix ["kube-apiserver: failover on multi-member etcd cluster fails certificate check on DNS mismatch" (kubernetes#83028)](https://github.com/kubernetes/kubernetes/issues/83028). | ||
- Improve [client balancer failover against IPv6 endpoints](https://github.com/etcd-io/etcd/pull/11211). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, the fix is for parsing IPv6 in etcd client, not necessarily related to client balancer failover. So maybe something like Fix IPv6 endpoint parsing in client
?
Given that they are bug fixes, maybe put these under section client v3
instead of breaking changes
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jingyih sure, sounds good. Thanks!!
54edc8d
to
a45b997
Compare
Can we name the section "Package |
Hi @gyuho thanks and I believe you are referencing changelog 3.3 and 3.4? If so, yes, I am fine with it but originally I put client v3 to keep it consistent with other places in the 3.3 and 3.4. (for example, |
oh ok. then this looks good as well |
OK Thanks @gyuho !! |
related #11184 #11211 #11354