*: log server-side /health checks #11704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier to root-cause when /health check fails. For example, we are using load balancer to health check each etcd instance, and when one etcd node gets terminated, it's hard to tell whether etcd "server" was really failing or client (or load balancer") failed to reach the etcd cluster which is also failure in load balancer health check. Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
|
/lgtm thanks! |
gyuho
added a commit
that referenced
this pull request
Mar 18, 2020
ref. #11704 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
Mar 18, 2020
ref. #11704 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
Mar 18, 2020
ref. #11704 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
Mar 18, 2020
ref. #11704 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
Mar 18, 2020
ref. #11704 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
added a commit
that referenced
this pull request
Mar 19, 2020
ref. #11704 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Feb 9, 2021
… in debug level When we have an external component that checks /health periodically, the etcd server logs can be quite verbose (e.g., DDOS-ing against insure etcd health check can lead to disk space full due to large log files). This change was introduced in etcd-io#11704. While we keep the warning logs for etcd health check failures, the success (or OK) log level should be set to DEBUG. Fixes etcd-io#12676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to root-cause when /health check fails.
For example, we are using load balancer to health check
each etcd instance, and when one etcd node gets terminated,
it's hard to tell whether etcd "server" was really failing
or client (or load balancer") failed to reach the etcd cluster
which is also failure in load balancer health check.