etcdserver/api/etcdhttp: log successful etcd server side health check in debug level #12677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in debug level When we have an external component that checks /health periodically, the etcd server logs can be quite verbose (e.g., DDOS-ing against insure etcd health check can lead to disk space full due to large log files). This change was introduced in etcd-io#11704. While we keep the warning logs for etcd health check failures, the success (or OK) log level should be set to DEBUG. Fixes etcd-io#12676
|
/cc @ptabor |
gyuho
reviewed
Feb 9, 2021
CHANGELOG-3.5.md
Outdated
| @@ -144,6 +144,7 @@ Note that any `etcd_debugging_*` metrics are experimental and subject to change. | |||
| - [Fix server panic](https://github.com/etcd-io/etcd/pull/12288) when force-new-cluster flag is enabled in a cluster which had learner node. | |||
| - Add [`--self-signed-cert-validity`](https://github.com/etcd-io/etcd/pull/12429) flag to support setting certificate expiration time. | |||
| - Notice, certificates generated by etcd are valid for 1 year by default when specifying the auto-tls or peer-auto-tls option. | |||
| - Log [successful etcd server-side health check in debug level](https://github.com/etcd-io/etcd/pull/12677). | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
ack. moved this CHANGELOG entry to line 118.
Codecov Report
@@ Coverage Diff @@
## master #12677 +/- ##
===========================================
- Coverage 68.70% 46.29% -22.42%
===========================================
Files 410 407 -3
Lines 32825 32804 -21
===========================================
- Hits 22553 15185 -7368
- Misses 8287 15657 +7370
+ Partials 1985 1962 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
spzala
reviewed
Feb 9, 2021
There was a problem hiding this comment.
lgtm after @gyuho 's comment is addressed.
Thanks @chaochn47
chaochn47
force-pushed
the
reduce_verbosity_of_etcd_server_side_success_health_check_logs
branch
from
9cef412
to
028d351
Compare
gyuho
approved these changes
Feb 9, 2021
|
@chaochn47 Can we backport this to release-3.4 branch? Thanks! |
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Feb 9, 2021
…de health check in debug level ref. etcd-io#12677 ref. etcd-io@0b9cfa8
chaochn47
deleted the
reduce_verbosity_of_etcd_server_side_success_health_check_logs
branch
hexfusion
pushed a commit
to hexfusion/etcd
that referenced
this pull request
Jun 16, 2021
…de health check in debug level ref. etcd-io#12677 ref. etcd-io@0b9cfa8
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Sep 8, 2022
…de health check in debug level ref. etcd-io#12677 ref. etcd-io@0b9cfa8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have an external component that checks /health periodically, the
etcd server logs can be quite verbose (e.g., DDOS-ing against insure
etcd health check can lead to disk space full due to large log files).
This change was introduced in #11704.
While we keep the warning logs for etcd health check failures, the
success (or OK) log level should be set to DEBUG.
Fixes #12676