-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdserver: add ConfChangeAddLearnerNode to the list of config changes #12288
etcdserver: add ConfChangeAddLearnerNode to the list of config changes #12288
Conversation
35b50b6
to
9fc6fa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a nit: could you also update line 617: s/two/three
We will need to backport this to 3.4 branch. |
To fix a panic that happens when trying to get ids of etcd members in force new cluster mode, the issue happen if the cluster previously had etcd learner nodes added to the cluster Fixes etcd-io#12285
9fc6fa3
to
7af8241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm Thanks @galal-hussein
For the reference, this PR is backported to release-3.4 via #12299. |
To fix a panic that happens when force-new-cluster flag is passed to
etcd node if the cluster had learner nodes added from before
Fixes #12285