update etcd to use rancher fork #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galal-hussein
force-pushed
the
use_etcd_fork
branch
from
7679c84
to
a7ff9aa
Compare
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
galal-hussein
force-pushed
the
use_etcd_fork
branch
from
a7ff9aa
to
4514269
Compare
brandond
approved these changes
Sep 11, 2020
briandowns
pushed a commit
to briandowns/k3s
that referenced
this pull request
Jan 14, 2021
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update etcd in go mod to use the rancher fork with the latest fix for the panic issue
Types of Changes
go mod change
Verification
we want to make sure that --cluster-reset works in HA mode
Linked Issues
#2131
#2227
Further Comments
The issue is a bug in etcd, and there is an issue opened in upstream and associated pr as well
etcd-io/etcd#12285
etcd-io/etcd#12288