Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] handle auth invalid token and old revision errors in watch #14548

Merged
merged 2 commits into from
Oct 4, 2022
Merged

[3.4] handle auth invalid token and old revision errors in watch #14548

merged 2 commits into from
Oct 4, 2022

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Oct 4, 2022

@mitake
*: handle auth invalid token and old revision errors in watch
0c6e466 
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
@mitake
tests: a test case for watch with auth token expiration
9136517 
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
@mitake mitake mentioned this pull request Oct 4, 2022
Merged
spzala
spzala approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mitake

ahrtr
ahrtr approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @mitake and @spzala

@ahrtr ahrtr merged commit de11726 into etcd-io:release-3.4 Oct 4, 2022
@mitake mitake deleted the 3.4-backport-14322 branch October 4, 2022 23:14
@mitake
Copy link
Contributor Author

mitake commented Oct 4, 2022

Thanks @ahrtr @spzala !

@ahrtr ahrtr mentioned this pull request Oct 29, 2022
Closed
4 tasks
@ahrtr ahrtr changed the title Backport PR 14322 to release-3.4 [3.4] handle auth invalid token and old revision errors in watch Oct 29, 2022
@EtienneM EtienneM mentioned this pull request Feb 7, 2023
Closed
This was referenced Mar 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@spzala spzala spzala approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitake @spzala @ahrtr