Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Revert 14548 #15542

Merged
merged 2 commits into from
Mar 21, 2023
Merged

[3.4] Revert 14548 #15542

merged 2 commits into from
Mar 21, 2023

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Mar 21, 2023

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

#14322 was backported to release-3.4 in #14548, but it should be reverted too.

cc @ahrtr @serathius

This reverts commit 0c6e466.

Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
This reverts commit 9136517.

Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
@mitake mitake changed the title Revert 14548 [3.4] Revert 14548 Mar 21, 2023
@ahrtr
Copy link
Member

ahrtr commented Mar 21, 2023

@mitake could you please also update the 3.4 changelog ?

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @mitake

@ahrtr ahrtr merged commit 336ac78 into etcd-io:release-3.4 Mar 21, 2023
@mitake mitake deleted the revert-14548-v2 branch March 24, 2023 14:36
@mitake
Copy link
Contributor Author

mitake commented Mar 24, 2023

Thanks @ahrtr @lavacat . I'll open a PR for updating the changelog tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants