Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate --experimental-warning-unary-request-duration to --warning-unary-request-duration #14803

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Nov 18, 2022

The first commit is coming from #14414

The original PR isn't responsive, and there is a long back and forth conversation session. The original PR overall looks good, so just resolve the minor comment myself, so that we can merge the PR soon.

cc @ptabor @serathius @spzala @lavacat

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #14803 (ebfcaae) into main (07a3cfe) will decrease coverage by 0.36%.
The diff coverage is 68.42%.

@@            Coverage Diff             @@
##             main   #14803      +/-   ##
==========================================
- Coverage   75.72%   75.35%   -0.37%     
==========================================
  Files         457      457              
  Lines       37377    37391      +14     
==========================================
- Hits        28302    28175     -127     
- Misses       7314     7428     +114     
- Partials     1761     1788      +27     
Flag Coverage Δ
all 75.35% <68.42%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/embed/config.go 74.48% <ø> (-0.07%) ⬇️
server/etcdmain/config.go 84.96% <66.66%> (-1.39%) ⬇️
server/embed/etcd.go 77.97% <100.00%> (ø)
server/proxy/grpcproxy/auth.go 44.44% <0.00%> (-44.45%) ⬇️
server/proxy/grpcproxy/maintenance.go 45.45% <0.00%> (-36.37%) ⬇️
server/proxy/grpcproxy/register.go 69.76% <0.00%> (-11.63%) ⬇️
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
server/storage/mvcc/watchable_store.go 85.14% <0.00%> (-8.34%) ⬇️
server/etcdserver/api/v3rpc/util.go 74.19% <0.00%> (-6.46%) ⬇️
client/v3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahrtr
Copy link
Member Author

ahrtr commented Nov 18, 2022

The linearizablity failure is caused by the gofail change (removed the gofail-go failpoint).

Once the PR #14804 is merged, then I need to rebase this PR.

Bogdan Kanivets and others added 2 commits November 18, 2022 18:06
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahrtr thanks, first graduate candidate after we put policies around graduation :),
lgtm, but have couple of small comments.

server/etcdmain/config.go Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-3.6.md Outdated Show resolved Hide resolved
server/etcdmain/help.go Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member Author

ahrtr commented Nov 18, 2022

@spzala Resolved all your comments. PTAL, thx.

1. Fixed the test failures which are caused by recent test framework rafactoring;
2. renamed the file to promote_experimental_flag_test.go.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@spzala
Copy link
Member

spzala commented Nov 18, 2022

@spzala Resolved all your comments. PTAL, thx.

Thanks @ahrtr

@ahrtr
Copy link
Member Author

ahrtr commented Nov 18, 2022

Thanks @spzala for the quick review.

@ahrtr ahrtr changed the title Promoted --experimental-warning-unary-request-duration to --warning-unary-request-duration Graduate --experimental-warning-unary-request-duration to --warning-unary-request-duration Nov 18, 2022
@ahrtr ahrtr merged commit ddd65e7 into etcd-io:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants