-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate --experimental-warning-unary-request-duration
to --warning-unary-request-duration
#14803
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14803 +/- ##
==========================================
- Coverage 75.72% 75.35% -0.37%
==========================================
Files 457 457
Lines 37377 37391 +14
==========================================
- Hits 28302 28175 -127
- Misses 7314 7428 +114
- Partials 1761 1788 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The linearizablity failure is caused by the gofail change (removed the gofail-go failpoint). Once the PR #14804 is merged, then I need to rebase this PR. |
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration experimental-warning-unary-request-duration will be removed in v3.7. fixes etcd-io#13783 Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
f141f43
to
94c2ec0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahrtr thanks, first graduate candidate after we put policies around graduation :),
lgtm, but have couple of small comments.
94c2ec0
to
76b6997
Compare
@spzala Resolved all your comments. PTAL, thx. |
1. Fixed the test failures which are caused by recent test framework rafactoring; 2. renamed the file to promote_experimental_flag_test.go. Signed-off-by: Benjamin Wang <wachao@vmware.com>
76b6997
to
ebfcaae
Compare
Thanks @spzala for the quick review. |
--experimental-warning-unary-request-duration
to --warning-unary-request-duration
--experimental-warning-unary-request-duration
to --warning-unary-request-duration
The first commit is coming from #14414
The original PR isn't responsive, and there is a long back and forth conversation session. The original PR overall looks good, so just resolve the minor comment myself, so that we can merge the PR soon.
cc @ptabor @serathius @spzala @lavacat