Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: bump gofail version #14804

Merged
merged 1 commit into from
Nov 18, 2022
Merged

tool: bump gofail version #14804

merged 1 commit into from
Nov 18, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Nov 18, 2022

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@ahrtr
Copy link
Member Author

ahrtr commented Nov 18, 2022

cc @serathius @spzala @ptabor

@codecov-commenter
Copy link

Codecov Report

Merging #14804 (150ea9d) into main (6d8139d) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14804      +/-   ##
==========================================
- Coverage   75.46%   75.36%   -0.11%     
==========================================
  Files         457      457              
  Lines       37375    37375              
==========================================
- Hits        28206    28166      -40     
- Misses       7396     7427      +31     
- Partials     1773     1782       +9     
Flag Coverage Δ
all 75.36% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/etcdserver/api/v3rpc/util.go 51.61% <0.00%> (-29.04%) ⬇️
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
client/v3/leasing/util.go 91.66% <0.00%> (-6.67%) ⬇️
client/v3/concurrency/session.go 88.63% <0.00%> (-4.55%) ⬇️
server/storage/mvcc/kvstore_compaction.go 95.65% <0.00%> (-4.35%) ⬇️
server/etcdserver/api/v3rpc/interceptor.go 74.47% <0.00%> (-3.13%) ⬇️
client/v3/concurrency/election.go 79.68% <0.00%> (-2.35%) ⬇️
server/etcdserver/api/v3rpc/watch.go 84.12% <0.00%> (-2.23%) ⬇️
server/etcdserver/apply/apply_auth.go 86.00% <0.00%> (-2.00%) ⬇️
pkg/traceutil/trace.go 96.15% <0.00%> (-1.93%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahrtr
Copy link
Member Author

ahrtr commented Nov 18, 2022

@serathius @spzala @ptabor The linearzability pipeline is breaking due to the removal of gofail-go failpoint in etcd-io/gofail#30. We need to get this PR merge soon.

@serathius serathius merged commit 07a3cfe into etcd-io:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants