Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 15656 to release-3.5 #15815

Merged
merged 2 commits into from
May 10, 2023
Merged

Conversation

mitake
Copy link
Contributor

@mitake mitake commented May 2, 2023

@ahrtr
Copy link
Member

ahrtr commented May 2, 2023

Will take a look after the workflow failures are resolved.

mitake and others added 2 commits May 8, 2023 22:45
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
Co-authored-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
Co-authored-by: Benjamin Wang <wachao@vmware.com>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mitake

@ahrtr
Copy link
Member

ahrtr commented May 10, 2023

@mitake Please add changelog item for both 3.5 and 3.4, thx

@ahrtr ahrtr merged commit d506948 into etcd-io:release-3.5 May 10, 2023
@serathius serathius mentioned this pull request May 10, 2023
4 tasks
tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants