server/etcdserver: swap order of return types #15844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
chaochn47
approved these changes
May 8, 2023
jmhbnz
approved these changes
May 8, 2023
ahrtr
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This is a follow up commit for #15656
The format check in release-3.5 branch (https://github.com/etcd-io/etcd/actions/runs/4867999645/jobs/8681084238?pr=15815) found that the order of return types of
checkLeaseTimeToLive()is invalid. It wasn't detected in main and release-3.4. This PR fixes that.The backport PRs (#15815 and #15814) have same style fix.
cc @ahrtr @spzala @serathius