Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/integration: deflake TestV3AuthWithLeaseRevokeWithRootJWT #16523

Merged

Conversation

YaoC
Copy link
Contributor

@YaoC YaoC commented Sep 2, 2023

For jwt, when:

  • ttl=1s, token will expire within (0, 1s].
  • ttl=2s, token will expire within (1s, 2s].

Update JWT ttl to 2s, so that it won't expire immediately. The token is only used in TestV3AuthWithLeaseRevokeWithRootJWT

func TestV3AuthWithLeaseRevokeWithRootJWT(t *testing.T) {
testV3AuthWithLeaseRevokeWithRoot(t, integration.ClusterConfig{Size: 1, AuthToken: integration.DefaultTokenJWT})
}

Close #16475

read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@YaoC YaoC force-pushed the deflake-TestV3AuthWithLeaseRevokeWithRootJWT branch from f9ac2de to 70b696f Compare September 2, 2023 06:20
Signed-off-by: Yao Cheng <chengyao09@hotmail.com>
@YaoC YaoC force-pushed the deflake-TestV3AuthWithLeaseRevokeWithRootJWT branch from 70b696f to d2a93eb Compare September 2, 2023 06:32
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for fixing this @YaoC.

@ahrtr ahrtr merged commit bc54bac into etcd-io:main Sep 4, 2023
@YaoC YaoC deleted the deflake-TestV3AuthWithLeaseRevokeWithRootJWT branch November 22, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Flaky integration test case TestV3AuthWithLeaseRevokeWithRootJWT
3 participants